Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run specs on GitHub Actions #3735

Draft
wants to merge 42 commits into
base: master
Choose a base branch
from
Draft

Conversation

lloeki
Copy link
Member

@lloeki lloeki commented Jun 25, 2024

What does this PR do?

Guess.

Motivation:

Hold my beer.

Additional Notes:

Trying stuff. May or may not work. But it allows me to test https://github.com/DataDog/images-rb without breaking CircleCI and something may or may not come out of it.

How to test the change?

Wait for it.

@lloeki lloeki requested a review from a team as a code owner June 25, 2024 13:36
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Jun 25, 2024
@lloeki lloeki marked this pull request as draft June 25, 2024 13:36
@github-actions github-actions bot removed the dev/github Github repository maintenance and automation label Jun 25, 2024
@lloeki
Copy link
Member Author

lloeki commented Jun 25, 2024

Draft PR, please <disregard> / <look the other way>.

@lloeki lloeki force-pushed the lloeki/run-specs-on-github-actions branch 13 times, most recently from a04442d to b26071f Compare June 28, 2024 16:38
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (75278d6) to head (4d67104).
Report is 107 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3735      +/-   ##
==========================================
- Coverage   98.10%   98.10%   -0.01%     
==========================================
  Files        1225     1225              
  Lines       72866    72847      -19     
  Branches     3493     3494       +1     
==========================================
- Hits        71485    71466      -19     
  Misses       1381     1381              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lloeki lloeki force-pushed the lloeki/run-specs-on-github-actions branch from 4d67104 to b40032a Compare September 4, 2024 14:09
@pr-commenter
Copy link

pr-commenter bot commented Sep 4, 2024

Benchmarks

Benchmark execution time: 2024-09-10 13:34:11

Comparing candidate commit 4655ea7 in PR branch lloeki/run-specs-on-github-actions with baseline commit ae50107 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

@lloeki lloeki force-pushed the lloeki/run-specs-on-github-actions branch from 28c2617 to 68db818 Compare September 10, 2024 12:21
@ivoanjo
Copy link
Member

ivoanjo commented Dec 9, 2024

Hey @lloeki is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants