chore(integrations): avoids using deprecated apis in ddtrace.patch(…) [backports 2.20]
#12153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…....)`` [3.0] (#12107) Ensures every integration defines their `patch`, `unpatch`, and/or `get_versions()` function in `ddtrace/contrib/internal/integration_name/patch.py`. This allows the `ddtrace.patch(...)` to load integrations from one well defined location. - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Vítor De Araújo <[email protected]> (cherry picked from commit 89fa5e5)
mabdinur
requested review from
ZStriker19,
duncanista,
emmettbutler and
wconti27
|
|
duncanista
approved these changes
Jan 30, 2025
mabdinur
changed the title
ddtrace.patch(…) [backports #12107 to 2.20]ddtrace.patch(…) [backports 2.20]
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 49.18s Total duration (35m 39.84s time saved) |
P403n1x87
approved these changes
Jan 30, 2025
emmettbutler
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports: #12107
Checklist 1
Checklist 2
policy