Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(llmobs): fix ragas version tagging #11984

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

lievan
Copy link
Contributor

@lievan lievan commented Jan 16, 2025

The ragas version was being stored & tagged as a tuple when it is supposed to be a string.

Fix by setting self.ragas_version to a string and then parsing afterwards

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@lievan lievan added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 16, 2025
@lievan lievan marked this pull request as ready for review January 16, 2025 15:01
@lievan lievan requested a review from a team as a code owner January 16, 2025 15:01
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/llmobs/_evaluators/ragas/base.py                                @DataDog/ml-observability

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: evan.li/fix-ragas-version-tag
Commit report: b4cf04e
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 26.14s Total duration (35m 21.69s time saved)

@lievan lievan enabled auto-merge (squash) January 16, 2025 15:30
@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2025

Benchmarks

Benchmark execution time: 2025-01-16 20:21:23

Comparing candidate commit 52218ce in PR branch evan.li/fix-ragas-version-tag with baseline commit 0275a5e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 378 metrics, 2 unstable metrics.

@lievan lievan merged commit e7403dc into main Jan 16, 2025
272 checks passed
@lievan lievan deleted the evan.li/fix-ragas-version-tag branch January 16, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants