Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky appsec tests #3013

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Fix flaky appsec tests #3013

merged 1 commit into from
Dec 24, 2024

Conversation

estringana
Copy link
Contributor

@estringana estringana commented Dec 24, 2024

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.56%. Comparing base (0926c77) to head (82734ce).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3013      +/-   ##
============================================
+ Coverage     72.74%   74.56%   +1.82%     
  Complexity     2750     2750              
============================================
  Files           138      111      -27     
  Lines         15060    10900    -4160     
  Branches       1026        0    -1026     
============================================
- Hits          10955     8128    -2827     
+ Misses         3546     2772     -774     
+ Partials        559        0     -559     
Flag Coverage Δ
appsec-extension ?
tracer-php 74.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0926c77...82734ce. Read the comment docs.

@estringana estringana marked this pull request as ready for review December 24, 2024 15:28
@estringana estringana requested a review from a team as a code owner December 24, 2024 15:28
@morrisonlevi morrisonlevi merged commit 40d7f8a into master Dec 24, 2024
671 of 697 checks passed
@morrisonlevi morrisonlevi deleted the estringana/fix-telemetry-tests branch December 24, 2024 17:32
@github-actions github-actions bot added this to the 1.6.0 milestone Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants