Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(doc): improve contributing.md #2998

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

dubloom
Copy link
Contributor

@dubloom dubloom commented Dec 17, 2024

Description

The CONTRIBUTING.md lacked information (run some specific tests for instance). In addition the command to launch the docker compose was not working.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@dubloom dubloom requested a review from a team as a code owner December 17, 2024 09:58
Copy link
Contributor

@PROFeNoM PROFeNoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.56%. Comparing base (0926c77) to head (5f7af6f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2998      +/-   ##
============================================
+ Coverage     72.74%   74.56%   +1.82%     
  Complexity     2750     2750              
============================================
  Files           138      111      -27     
  Lines         15060    10900    -4160     
  Branches       1026        0    -1026     
============================================
- Hits          10955     8128    -2827     
+ Misses         3546     2772     -774     
+ Partials        559        0     -559     
Flag Coverage Δ
appsec-extension ?
tracer-php 74.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0926c77...5f7af6f. Read the comment docs.

@dubloom dubloom merged commit d1cfb1e into master Dec 17, 2024
666 of 698 checks passed
@dubloom dubloom deleted the dubloom/update-contributing branch December 17, 2024 16:28
@github-actions github-actions bot added this to the 1.6.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants