Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix libdatadog commit #2996

Merged
merged 1 commit into from
Dec 16, 2024
Merged

build: fix libdatadog commit #2996

merged 1 commit into from
Dec 16, 2024

Conversation

morrisonlevi
Copy link
Collaborator

@morrisonlevi morrisonlevi commented Dec 16, 2024

Description

Was previously pointing to an unmerged commit.

Note that there were newer commits on libdatadog than the one I committed--the goal is to strictly get the build passing again and so I only went to the one that merged the commit.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi morrisonlevi requested a review from a team as a code owner December 16, 2024 04:46
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.56%. Comparing base (4cc2897) to head (149de2a).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2996      +/-   ##
============================================
+ Coverage     72.75%   74.56%   +1.81%     
  Complexity     2750     2750              
============================================
  Files           138      111      -27     
  Lines         15038    10900    -4138     
  Branches       1020        0    -1020     
============================================
- Hits          10941     8128    -2813     
+ Misses         3543     2772     -771     
+ Partials        554        0     -554     
Flag Coverage Δ
appsec-extension ?
tracer-php 74.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc2897...149de2a. Read the comment docs.

@realFlowControl realFlowControl merged commit 978658e into master Dec 16, 2024
667 of 699 checks passed
@realFlowControl realFlowControl deleted the levi/fix-libdatadog branch December 16, 2024 07:04
@github-actions github-actions bot added this to the 1.6.0 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants