-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(profiling): mismatch in utf8 handling #2990
Conversation
Happens in timeline filename for zend_error_observer.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2990 +/- ##
============================================
+ Coverage 72.90% 74.82% +1.91%
Complexity 2741 2741
============================================
Files 137 110 -27
Lines 14978 10863 -4115
Branches 1016 0 -1016
============================================
- Hits 10920 8128 -2792
+ Misses 3506 2735 -771
+ Partials 552 0 -552
Flags with carried forward coverage won't be shown. Click here to find out more. see 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Benchmarks [ profiler ]Benchmark execution time: 2024-12-12 07:08:02 Comparing candidate commit f013c40 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 7 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Description
Happens in timeline filename for zend_error_observer.
I found this mismatch while doing something else. I asked Florian about it and he prepared a different way to fix it in #2988. I thought I'd push mine up too so we can compare.
Reviewer checklist