Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): mismatch in utf8 handling #2990

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Conversation

morrisonlevi
Copy link
Collaborator

@morrisonlevi morrisonlevi commented Dec 11, 2024

Description

Happens in timeline filename for zend_error_observer.

I found this mismatch while doing something else. I asked Florian about it and he prepared a different way to fix it in #2988. I thought I'd push mine up too so we can compare.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

Happens in timeline filename for zend_error_observer.
@morrisonlevi morrisonlevi requested review from a team as code owners December 11, 2024 17:04
@github-actions github-actions bot added the profiling Relates to the Continuous Profiler label Dec 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (8273bb7) to head (f013c40).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2990      +/-   ##
============================================
+ Coverage     72.90%   74.82%   +1.91%     
  Complexity     2741     2741              
============================================
  Files           137      110      -27     
  Lines         14978    10863    -4115     
  Branches       1016        0    -1016     
============================================
- Hits          10920     8128    -2792     
+ Misses         3506     2735     -771     
+ Partials        552        0     -552     
Flag Coverage Δ
appsec-extension ?
tracer-php 74.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8273bb7...f013c40. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Dec 11, 2024

Benchmarks [ profiler ]

Benchmark execution time: 2024-12-12 07:08:02

Comparing candidate commit f013c40 in PR branch levi/filename-fix with baseline commit 8273bb7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 7 unstable metrics.

Copy link
Member

@realFlowControl realFlowControl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

profiling/src/timeline.rs Outdated Show resolved Hide resolved
profiling/src/timeline.rs Outdated Show resolved Hide resolved
@realFlowControl realFlowControl merged commit 4bf79f2 into master Dec 12, 2024
454 of 511 checks passed
@realFlowControl realFlowControl deleted the levi/filename-fix branch December 12, 2024 07:13
@github-actions github-actions bot added this to the 1.6.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants