Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loader] Exit if execv failed #2983

Merged
merged 2 commits into from
Dec 6, 2024
Merged

[loader] Exit if execv failed #2983

merged 2 commits into from
Dec 6, 2024

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Dec 4, 2024

Description

if execv fails, we must exit immediately

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@iamluc iamluc requested a review from a team as a code owner December 4, 2024 14:09
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (34baa56) to head (ec7518a).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2983      +/-   ##
============================================
+ Coverage     73.12%   74.82%   +1.70%     
  Complexity     2741     2741              
============================================
  Files           137      110      -27     
  Lines         14907    10863    -4044     
  Branches        992        0     -992     
============================================
- Hits          10900     8128    -2772     
+ Misses         3462     2735     -727     
+ Partials        545        0     -545     
Flag Coverage Δ
appsec-extension ?
tracer-php 74.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34baa56...ec7518a. Read the comment docs.

@iamluc iamluc merged commit 196c7f2 into master Dec 6, 2024
647 of 669 checks passed
@iamluc iamluc deleted the luc/loader-safe-exit branch December 6, 2024 07:46
@github-actions github-actions bot added this to the 1.6.0 milestone Dec 6, 2024
@bwoebi bwoebi mentioned this pull request Jan 8, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants