Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling) support new ZendMM api #2969

Merged
merged 12 commits into from
Jan 14, 2025
Merged

Conversation

realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Nov 20, 2024

Description

This PR changes the way we hook into the ZendMM starting from PHP 8.4 thanks to the new ZendMM API that got introduced in php/php-src#13432

PROF-10116

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@github-actions github-actions bot added the profiling Relates to the Continuous Profiler label Nov 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.78%. Comparing base (c73b7f7) to head (af5825e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2969      +/-   ##
============================================
+ Coverage     72.93%   74.78%   +1.84%     
  Complexity     2781     2781              
============================================
  Files           139      112      -27     
  Lines         15166    11017    -4149     
  Branches       1022        0    -1022     
============================================
- Hits          11062     8239    -2823     
+ Misses         3552     2778     -774     
+ Partials        552        0     -552     
Flag Coverage Δ
appsec-extension ?
tracer-php 74.78% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c73b7f7...af5825e. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Nov 20, 2024

Benchmarks [ profiler ]

Benchmark execution time: 2025-01-14 08:14:19

Comparing candidate commit af5825e in PR branch florian/new-zendmm with baseline commit c73b7f7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics.

@realFlowControl realFlowControl force-pushed the florian/new-zendmm branch 5 times, most recently from 1ef435b to 9f23f8d Compare November 26, 2024 15:16
@realFlowControl realFlowControl marked this pull request as ready for review November 29, 2024 09:48
@realFlowControl realFlowControl requested a review from a team as a code owner November 29, 2024 09:48
@realFlowControl realFlowControl force-pushed the florian/new-zendmm branch 4 times, most recently from 146d1ec to ca68121 Compare December 2, 2024 15:47
@realFlowControl realFlowControl marked this pull request as draft December 2, 2024 15:49
@realFlowControl realFlowControl force-pushed the florian/new-zendmm branch 2 times, most recently from 840daa4 to e0e3862 Compare December 2, 2024 16:51
@realFlowControl realFlowControl marked this pull request as ready for review December 4, 2024 10:40
profiling/build.rs Show resolved Hide resolved
profiling/src/allocation/mod.rs Outdated Show resolved Hide resolved
@realFlowControl realFlowControl force-pushed the florian/new-zendmm branch 3 times, most recently from 4bd7be9 to 9c9742c Compare December 5, 2024 11:05
@realFlowControl realFlowControl merged commit 46ec759 into master Jan 14, 2025
690 of 736 checks passed
@realFlowControl realFlowControl deleted the florian/new-zendmm branch January 14, 2025 15:58
@github-actions github-actions bot added this to the 1.7.0 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants