Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 'debug' versions from the SSI package to reduce its size #2964

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Nov 19, 2024

Description

With the release of the version 1.5.0 (and the addition of PHP 8.4), we exceed the limitation of 120MB we set for the Kubernetes injection image.

Let's remove the debug versions that should not be used except in a local dev environment.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@iamluc iamluc requested a review from a team as a code owner November 19, 2024 08:42
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.75%. Comparing base (93849dd) to head (bea0bf7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2964   +/-   ##
=========================================
  Coverage     74.75%   74.75%           
  Complexity     2741     2741           
=========================================
  Files           110      110           
  Lines         10835    10835           
=========================================
  Hits           8100     8100           
  Misses         2735     2735           
Flag Coverage Δ
tracer-php 74.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93849dd...bea0bf7. Read the comment docs.

---- 🚨 Try these New Features:

@iamluc iamluc force-pushed the luc/ssi-package-remove-debug branch from bdb06ec to 1c79985 Compare November 19, 2024 09:44
@iamluc iamluc force-pushed the luc/ssi-package-remove-debug branch from 1c79985 to bea0bf7 Compare November 19, 2024 11:09
@iamluc iamluc merged commit 66ba88f into master Nov 19, 2024
681 of 722 checks passed
@iamluc iamluc deleted the luc/ssi-package-remove-debug branch November 19, 2024 14:22
@iamluc iamluc restored the luc/ssi-package-remove-debug branch November 19, 2024 14:22
@iamluc iamluc deleted the luc/ssi-package-remove-debug branch November 19, 2024 14:22
@github-actions github-actions bot added this to the 1.6.0 milestone Nov 19, 2024
@bwoebi bwoebi modified the milestones: 1.6.0, 1.5.1 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants