-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WAF telemetry #2735
WAF telemetry #2735
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2735 +/- ##
============================================
- Coverage 74.82% 72.90% -1.92%
Complexity 2741 2741
============================================
Files 110 137 +27
Lines 10863 14978 +4115
Branches 0 1016 +1016
============================================
+ Hits 8128 10920 +2792
- Misses 2735 3506 +771
- Partials 0 552 +552
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 23 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
BenchmarksBenchmark execution time: 2024-07-13 00:47:21 Comparing candidate commit a225a90 in PR branch Found 17 performance improvements and 0 performance regressions! Performance is the same for 161 metrics, 0 unstable metrics. scenario:EmptyFileBench/benchEmptyFileBaseline
scenario:EmptyFileBench/benchEmptyFileBaseline-opcache
scenario:EmptyFileBench/benchEmptyFileOverhead
scenario:EmptyFileBench/benchEmptyFileOverhead-opcache
scenario:LaravelBench/benchLaravelBaseline
scenario:LaravelBench/benchLaravelBaseline-opcache
scenario:LaravelBench/benchLaravelOverhead
scenario:LaravelBench/benchLaravelOverhead-opcache
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:SymfonyBench/benchSymfonyBaseline
scenario:SymfonyBench/benchSymfonyBaseline-opcache
scenario:SymfonyBench/benchSymfonyOverhead
scenario:SymfonyBench/benchSymfonyOverhead-opcache
scenario:TraceSerializationBench/benchSerializeTrace
scenario:TraceSerializationBench/benchSerializeTrace-opcache
scenario:WordPressBench/benchWordPressOverhead
scenario:WordPressBench/benchWordPressOverhead-opcache
|
8464095
to
d91cd3f
Compare
e777ab6
to
8239978
Compare
8239978
to
3cdc077
Compare
6b37ec2
to
ad72485
Compare
1b22395
to
a225a90
Compare
a225a90
to
ff61a19
Compare
Benchmarks [ tracer ]Benchmark execution time: 2024-12-06 17:37:19 Comparing candidate commit b30d87e in PR branch Found 3 performance improvements and 2 performance regressions! Performance is the same for 173 metrics, 0 unstable metrics. scenario:ComposerTelemetryBench/benchTelemetryParsing
scenario:PDOBench/benchPDOBaseline
scenario:PDOBench/benchPDOBaseline-opcache
scenario:SamplingRuleMatchingBench/benchRegexMatching4
scenario:TraceFlushBench/benchFlushTrace
|
Benchmarks [ appsec ]Benchmark execution time: 2024-12-06 17:47:06 Comparing candidate commit b30d87e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. |
4e07791
to
e00d8b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a number of comments, everything looks correct albeit there could be some improvements around the helper telemetry API and the naming conventions.
9ae5168
to
7f4cb58
Compare
7f4cb58
to
b3f6f9f
Compare
15e82d8
to
43b9267
Compare
43b9267
to
b30d87e
Compare
Description
See individual commits for descriptions of the changes.
Reviewer checklist