Taint objects #94
Merged
Taint objects #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iunanua
commented
Jan 12, 2024
iunanua
commented
Jan 12, 2024
hoolioh
approved these changes
Jan 18, 2024
CarlesDD
reviewed
Jan 18, 2024
| return; | ||
| } | ||
|
|
||
| if ((args[1]->IsString())) { |
There was a problem hiding this comment.
Extra pair of parenthesis
| @@ -58,6 +61,7 @@ try { | |||
|
|
|||
| const iastNativeMethods = { | |||
| newTaintedString: addon.newTaintedString, | |||
| newTaintedObject: addon.newTaintedObject, | |||
There was a problem hiding this comment.
Type declaration for the new method in index.d.ts file is missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Exposes the
newTaintedObjectmethod to taint objects.Motivation
Allow IAST to taint Buffer objects used for example by kafka consumers
Additional Notes
Checklist