Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support node 23 #111

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Support node 23 #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1520890
Support node 23
uurien Oct 16, 2024
faf1a1d
Use c++20
uurien Oct 17, 2024
868b6b9
Try to build using a commit version
uurien Oct 21, 2024
f6f6a84
Update binding.gyp
uurien Oct 21, 2024
56d47c5
Restore `Datadog/action-prebuildify@main`
uurien Oct 22, 2024
d701c38
Update c++ version also in CMakeLists.txt
uurien Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
needs: ['cpp-lint', 'js-lint']
strategy:
matrix:
version: [16, 17, 18, 19, 20, 21, 22]
version: [16, 17, 18, 19, 20, 21, 22, 23]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -28,7 +28,7 @@ jobs:
needs: ['cpp-lint', 'js-lint']
strategy:
matrix:
version: [16, 17, 18, 19, 20, 21, 22]
version: [16, 17, 18, 19, 20, 21, 22, 23]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
needs: ['cpp-lint', 'js-lint']
strategy:
matrix:
version: [16, 18, 19, 20, 21, 22]
version: [16, 18, 19, 20, 21, 22, 23]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -24,7 +24,7 @@ jobs:
needs: ['cpp-lint', 'js-lint']
strategy:
matrix:
version: [16, 18, 19, 20, 21, 22]
version: [16, 18, 19, 20, 21, 22, 23]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
cmake_minimum_required(VERSION 3.9)
cmake_policy(SET CMP0042 NEW)
set (CMAKE_CXX_STANDARD 17)
set (CMAKE_CXX_STANDARD 20)
set (CMAKE_CXX_COMPILER clang++)

project(dd-native-iast-taint-tracking-js)
Expand Down
13 changes: 9 additions & 4 deletions binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,20 @@
"<!(node -e \"require('nan')\")"
],
"cflags!": [ "-fno-exceptions", "-fno-rtti" ],
"cflags_cc!": [ "-fno-exceptions", "-fno-rtti" ],
"cflags_cc": [ "-std=c++17" ],
"cflags_cc!": [ "-fno-exceptions", "-fno-rtti", "-std=gnu++20" ],
"cflags_cc": [ "-std=gnu++2a" ],
CarlesDD marked this conversation as resolved.
Show resolved Hide resolved
"conditions": [
['OS=="mac"', {
"xcode_settings": {
"MACOSX_DEPLOYMENT_TARGET": "10.7",
"MACOSX_DEPLOYMENT_TARGET": "10.10",
"CLANG_CXX_LIBRARY": "libc++",
"GCC_ENABLE_CPP_EXCEPTIONS": "YES",
"GCC_ENABLE_CPP_RTTI": "YES"
"GCC_ENABLE_CPP_RTTI": "YES",
"OTHER_CFLAGS": [
"-std=c++20",
"-stdlib=libc++",
"-Wall"
]
}
}],
['OS=="win"', {
Expand Down
Loading