Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for node 22 #103

Merged
merged 6 commits into from
May 2, 2024
Merged

Add support for node 22 #103

merged 6 commits into from
May 2, 2024

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented Apr 26, 2024

What does this PR do?

  • Adds support for node 22
  • Updates download-artifact and upload-artifact to v4 because actions-prebuildify is using it.

@uurien uurien changed the title Add support for new node 22 Add support for node 22 Apr 29, 2024
@uurien uurien marked this pull request as ready for review April 30, 2024 07:45
@uurien uurien requested a review from a team as a code owner April 30, 2024 07:45
Copy link
Collaborator

@CarlesDD CarlesDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss the upgrade of upload and download artifact actions for release job.

@uurien
Copy link
Collaborator Author

uurien commented Apr 30, 2024

I miss the upgrade of upload and download artifact actions for release job.

Yes, good catch!

@CarlesDD CarlesDD merged commit 731efed into main May 2, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants