[AWS log forwarder] Generate new objects per each received event record in AWS logs handler #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WS logs handler The logs forwarder shares the same AWS log handler for multiple event types i.e. Kinesis and Cloudwatch logs. For Kinesis event types, there's a chance of receiving log records from several log group sources as the order is not guaranteed. Therefore, setting unified attributes such as log_group or log_source per event leads to a random behavior when setting the host, service, source and other metadata parameters. To prevent this random behavior, regenerate a new metadata and attributes object per each received event record in the logs handler.
ge0Aja
changed the title
tyrcho
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
AWS Logs forwarder shares the same AWS log handler for multiple event types i.e. Kinesis and Cloudwatch logs. For Kinesis event types, there's a chance of receiving log records from several log group sources as the order is not guaranteed. Therefore, setting unified attributes such as log_group or log_source per event leads to a random behavior when setting the host, service, source and other metadata parameters. To prevent this random behavior, regenerate a new metadata and attributes object per each received event record in the logs handler.
Motivation
Support ask
Testing Guidelines
Additional Notes
Types of changes
Check all that apply