Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DT-940] Centralize the GitHub Action Slack configuration #179

Merged
merged 2 commits into from
Oct 29, 2024
+12 −5
Merged

[DT-940] Centralize the GitHub Action Slack configuration #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63310e1
feat: configure slack channel with a single variable
fboulnois Oct 28, 2024
f348151
feat: add CODEOWNERS file while we're at it
fboulnois Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Lines starting with '#' are comments.
# Each line is a file pattern followed by one or more owners.
# Documentation with syntax examples:
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

# These owners will be the default owners for everything in the repo.
* @DataBiosphere/dsp-data-team-eng
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ jobs:
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
with:
channel: '#dsp-data-exploration'
channel: ${{ vars.SLACK_NOTIFICATION_CHANNELS }}
status: failure
author_name: Build on dev
fields: job,message
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,13 +107,13 @@ jobs:
if: failure()

steps:
- name: "Notify #dsp-data-exploration Slack on failure"
- name: "Notify Slack channel on failure"
uses: broadinstitute/[email protected]
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
STATUS: failure
with:
channel: '#dsp-data-exploration'
channel: ${{ vars.SLACK_NOTIFICATION_CHANNELS }}
status: ${{ env.STATUS }}
fields: job,ref
text: >
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
with:
channel: '#dsp-data-exploration'
channel: ${{ vars.SLACK_NOTIFICATION_CHANNELS }}
status: failure
author_name: Publish to dev
fields: job
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trivy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
with:
channel: '#dsp-data-exploration'
channel: ${{ vars.SLACK_NOTIFICATION_CHANNELS }}
status: failure
author_name: Trivy action
fields: workflow,message
Expand Down
Loading