Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AFUS Dog Transformations #225

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

AFUS Dog Transformations #225

wants to merge 18 commits into from

Conversation

quazi-h
Copy link
Contributor

@quazi-h quazi-h commented Jan 19, 2022

Why

Extraction and transformation pipeline for the afus_dog tables.
Relevant ticket

This PR

Added forms needed for afus_dog extraction.
Added schema fragments, pipeline builder, and transformation scripts for afus_dog.

Checklist

  • Documentation has been updated as needed.

…ers, arm generator logic.

Need to update standardDirectives and dateFilters if any are to be implemented (check w/ Matt).
Added unit and integration tests for the new extraction pipeline.
Removing bad test cases (will not hold up over time).
Reducing idBatchSize to 10 to prevent overloading RedCap.
Updated tests, removed debugging changes.
…r table was added as well.

Created a new TransformationHelper function to process AFUS records where data for a single record is spread across multiple arms.
Added tests: pipeline test, unit tests for the owner transformations, and new transformation helper method.
Updated unit tests to make sure we are trimming whitespace.
Added schema, pipeline builder, and transformation scripts for afus_dog.
Added AfusDogDemographics and AfusDogResidence transformation.
…consistent failures.

Extended transformation pipeline tests.
Refactored a common TransformationLog file to encapsulate the errors and warnings for all surveys and updated imports.
case Some(event) => Some(event.split("_")(1).toLong)
case None => None
},
//Some(redcapEvent.split("_")(1).filter(_.isDigit).toLong),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these commented out?

Copy link
Contributor

@aherbst-broad aherbst-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants