-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AFUS Dog Transformations #225
Open
quazi-h
wants to merge
18
commits into
master
Choose a base branch
from
qh-dspdc-1958-afus-dog
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers, arm generator logic. Need to update standardDirectives and dateFilters if any are to be implemented (check w/ Matt). Added unit and integration tests for the new extraction pipeline.
Removing bad test cases (will not hold up over time).
Reducing idBatchSize to 10 to prevent overloading RedCap. Updated tests, removed debugging changes.
…r table was added as well. Created a new TransformationHelper function to process AFUS records where data for a single record is spread across multiple arms. Added tests: pipeline test, unit tests for the owner transformations, and new transformation helper method.
Updated unit tests to make sure we are trimming whitespace.
…e value as a long"
Added schema, pipeline builder, and transformation scripts for afus_dog. Added AfusDogDemographics and AfusDogResidence transformation.
…consistent failures. Extended transformation pipeline tests.
Refactored a common TransformationLog file to encapsulate the errors and warnings for all surveys and updated imports.
case Some(event) => Some(event.split("_")(1).toLong) | ||
case None => None | ||
}, | ||
//Some(redcapEvent.split("_")(1).filter(_.isDigit).toLong), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these commented out?
aherbst-broad
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Extraction and transformation pipeline for the afus_dog tables.
Relevant ticket
This PR
Added forms needed for afus_dog extraction.
Added schema fragments, pipeline builder, and transformation scripts for afus_dog.
Checklist