Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix anvilprod: anvil8 snapshot not available (#6661) #6662

Conversation

dsotirho-ucsc
Copy link
Contributor

@dsotirho-ucsc dsotirho-ucsc commented Oct 26, 2024

Connected issue: #6661

Notes

  • Requires a targeted reindex of anvil8 on hammerbox and anvilprod

Checklist

Author

  • Target branch is anvilprod promotions/2024-10-22-anvilprod
  • Name of PR branch matches hotfixes/<GitHub handle of author>/<issue#>-<slug>-anvilprod
  • On ZenHub, PR is connected to the issue it hotfixes
  • PR description links to connected issue
  • PR title is Hotfix anvilprod: followed by title of connected issue
  • PR title references the connected issue

Author (hotfixes)

  • Added h tag to commit title or this PR does not include a temporary hotfix
  • Added H tag to commit title or this PR does not include a permanent hotfix
  • Added hotfix label to PR
  • This PR is labeled partial or represents a permanent hotfix

Author (before every review)

  • Rebased PR branch on anvilprod promotions/2024-10-22-anvilprod, squashed old fixups
  • Ran make requirements_update or this PR does not modify requirements*.txt, common.mk, Makefile and Dockerfile
  • Added R tag to commit title or this PR does not modify requirements*.txt
  • This PR is labeled reqs or does not modify requirements*.txt

System administrator (after approval)

  • Actually approved the PR
  • Decided if PR can be labeled no sandbox
  • A comment to this PR details the completed security design review
  • PR title is appropriate as title of merge commit
  • Moved connected issue to Approved column
  • PR is assigned to only the operator

Operator (before pushing merge the commit)

  • Squashed PR branch and rebased onto anvilprod
  • Sanity-checked history
  • Pushed PR branch to GitHub
  • Added sandbox label or PR is labeled no sandbox
  • Pushed PR branch to GitLab anvilprod or PR is labeled no sandbox
  • Build passes in hammerbox deployment or PR is labeled no sandbox
  • Reviewed build logs for anomalies in hammerbox deployment or PR is labeled no sandbox
  • The title of the merge commit starts with the title of this PR
  • Added PR # reference to merge commit title
  • Collected commit title tags in merge commit title but excluded any p tags
  • Moved connected issue to Merged stable column in ZenHub
  • Pushed merge commit to GitHub

Operator (after pushing the merge commit)

  • Pushed merge commit to GitLab anvilprod
  • Build passes on GitLab anvilprod
  • Reviewed build logs for anomalies on GitLab anvilprod
  • Deleted PR branch from GitHub
  • Deleted PR branch from GitLab anvilprod

Operator (reindex)

  • Deindexed all unreferenced catalogs in anvilprod or this PR is neither labeled reindex:partial nor reindex:anvilprod
  • Deindexed specific sources in anvilprod or this PR is neither labeled reindex:partial nor reindex:anvilprod
  • Indexed specific sources in anvilprod or this PR is neither labeled reindex:partial nor reindex:anvilprod
  • Started reindex in anvilprod or neither this PR nor a failed, prior promotion requires it
  • Checked for, triaged and possibly requeued messages in both fail queues in anvilprod or neither this PR nor a failed, prior promotion requires it
  • Emptied fail queues in anvilprod or neither this PR nor a failed, prior promotion requires it
  • Created backport PR and linked to it in a comment on this PR

Operator

  • PR is assigned to no one

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

@dsotirho-ucsc dsotirho-ucsc added partial [process] PR is does not completely resolve associated ticket hotfix [process] An PR with an urgent fix for prod labels Oct 26, 2024
@github-actions github-actions bot added the orange [process] Done by the Azul team label Oct 26, 2024
@dsotirho-ucsc dsotirho-ucsc added reindex:anvilprod [process] PR requires reindexing anvilprod reindex:partial [process] PR allows for (de)indexing a specific source or catalog labels Oct 26, 2024
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.34%. Comparing base (35c9573) to head (4293987).
Report is 1 commits behind head on promotions/2024-10-22-anvilprod.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           promotions/2024-10-22-anvilprod    #6662   +/-   ##
================================================================
  Coverage                            85.34%   85.34%           
================================================================
  Files                                  155      155           
  Lines                                20782    20782           
================================================================
  Hits                                 17736    17736           
  Misses                                3046     3046           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsotirho-ucsc
Copy link
Contributor Author

Closing this hotfix PR, instead a commit will be added to the anviilprod promotion PR #6653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix [process] An PR with an urgent fix for prod orange [process] Done by the Azul team partial [process] PR is does not completely resolve associated ticket reindex:anvilprod [process] PR requires reindexing anvilprod reindex:partial [process] PR allows for (de)indexing a specific source or catalog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants