Merge pull request #364 from DarthAffe/Development

v2.0.0

.github/workflows/ci.yml

@@ -11,16 +11,19 @@ on:
 jobs:
   build:
 
-    runs-on: windows-2022
+    runs-on: windows-latest
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
       with:
         fetch-depth: 0
     - name: Setup .NET
-      uses: actions/setup-dotnet@v1
+      uses: actions/setup-dotnet@v3
       with:
-        dotnet-version: 7.0.x        
+        dotnet-version: |
+          8.0.x
+          7.0.x
+          6.0.x
     - name: Git Semantic Version
       id: versioning
       uses: PaulHatch/[email protected]
@@ -33,12 +36,6 @@ jobs:
       run: dotnet build --no-restore --configuration Release /p:Version=${{ steps.versioning.outputs.version }}
     - name: Test
       run: dotnet test --no-build --verbosity normal --configuration Release
-    - name: Upload a Build Artifact NET5
-      uses: actions/[email protected]
-      with:
-        name: RGB.NET-NET5
-        path: bin/net5.0/RGB.NET.*.dll
-        if-no-files-found: error
     - name: Upload a Build Artifact NET6
       uses: actions/[email protected]
       with:
@@ -51,6 +48,12 @@ jobs:
         name: RGB.NET-NET7
         path: bin/net7.0/RGB.NET.*.dll
         if-no-files-found: error
+    - name: Upload a Build Artifact NET8
+      uses: actions/[email protected]
+      with:
+        name: RGB.NET-NET8
+        path: bin/net8.0/RGB.NET.*.dll
+        if-no-files-found: error
     - name: Upload Nuget Build Artifact
       uses: actions/[email protected]
       with:
@@ -59,3 +62,11 @@ jobs:
         if-no-files-found: error
     - name: Nuget Push
       run: dotnet nuget push **\*.nupkg --skip-duplicate --api-key ${{ secrets.NUGET_TOKEN }} --source https://api.nuget.org/v3/index.json
+    - name: Symbols Push
+      run: dotnet nuget push **\*.snupkg --skip-duplicate --api-key ${{ secrets.NUGET_TOKEN }} --source https://api.nuget.org/v3/index.json
+    - name: Create Tag
+      uses: mathieudutour/[email protected]
+      with:
+        github_token: ${{ secrets.GITHUB_TOKEN }}
+        custom_tag: ${{ steps.versioning.outputs.version }}
+        tag_prefix: v

.github/workflows/pr_verify.yml

@@ -7,14 +7,17 @@ on:
 jobs:
   build:
 
-    runs-on: windows-2022
+    runs-on: windows-latest
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Setup .NET
-      uses: actions/setup-dotnet@v1
+      uses: actions/setup-dotnet@v3
       with:
-        dotnet-version: 7.0.x
+        dotnet-version: |
+          8.0.x
+          7.0.x
+          6.0.x
     - name: Restore dependencies
       run: dotnet restore
     - name: Build

.github/workflows/release.yml

@@ -10,16 +10,19 @@ on:
 
 jobs:
   build:
-    runs-on: windows-2022
+    runs-on: windows-latest
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
       with:
         fetch-depth: 0
     - name: Setup .NET
-      uses: actions/setup-dotnet@v1
+      uses: actions/setup-dotnet@v3
       with:
-        dotnet-version: 7.0.x        
+        dotnet-version: |
+          8.0.x
+          7.0.x
+          6.0.x  
     - name: Git Semantic Version
       id: versioning
       uses: PaulHatch/[email protected]
@@ -32,12 +35,6 @@ jobs:
       run: dotnet build --no-restore --configuration Release /p:Version=${{ steps.versioning.outputs.version }}
     - name: Test
       run: dotnet test --no-build --verbosity normal --configuration Release
-    - name: Upload a Build Artifact NET5
-      uses: actions/[email protected]
-      with:
-        name: RGB.NET-NET5
-        path: bin/net5.0/RGB.NET.*.dll
-        if-no-files-found: error
     - name: Upload a Build Artifact NET6
       uses: actions/[email protected]
       with:
@@ -50,6 +47,12 @@ jobs:
         name: RGB.NET-NET7
         path: bin/net7.0/RGB.NET.*.dll
         if-no-files-found: error
+    - name: Upload a Build Artifact NET8
+      uses: actions/[email protected]
+      with:
+        name: RGB.NET-NET8
+        path: bin/net8.0/RGB.NET.*.dll
+        if-no-files-found: error
     - name: Upload Nuget Build Artifact
       uses: actions/[email protected]
       with:
@@ -61,6 +64,6 @@ jobs:
       with:
         tag_name: ${{ steps.versioning.outputs.version_tag }}
         generate_release_notes: true
-        files: bin/net7.0/RGB.NET.*.dll
+        files: bin/net8.0/RGB.NET.*.dll
     - name: Nuget Push
       run: dotnet nuget push **\*.nupkg --skip-duplicate --api-key ${{ secrets.NUGET_TOKEN }} --source https://api.nuget.org/v3/index.json

RGB.NET.Core/Color/Behaviors/DefaultColorBehavior.cs

@@ -6,44 +6,47 @@ namespace RGB.NET.Core;
 /// <summary>
 /// Represents the default-behavior for the work with colors.
 /// </summary>
-public class DefaultColorBehavior : IColorBehavior
+public sealed class DefaultColorBehavior : IColorBehavior
 {
     #region Methods
 
     /// <summary>
     /// Converts the individual byte values of this <see cref="Color"/> to a human-readable string.
     /// </summary>
     /// <returns>A string that contains the individual byte values of this <see cref="Color"/>. For example "[A: 255, R: 255, G: 0, B: 0]".</returns>
-    public virtual string ToString(in Color color) => $"[A: {color.GetA()}, R: {color.GetR()}, G: {color.GetG()}, B: {color.GetB()}]";
+    public string ToString(in Color color) => $"[A: {color.GetA()}, R: {color.GetR()}, G: {color.GetG()}, B: {color.GetB()}]";
 
     /// <summary>
     /// Tests whether the specified object is a <see cref="Color" /> and is equivalent to this <see cref="Color" />.
     /// </summary>
     /// <param name="color">The color to test.</param>
     /// <param name="obj">The object to test.</param>
     /// <returns><c>true</c> if <paramref name="obj" /> is a <see cref="Color" /> equivalent to this <see cref="Color" />; otherwise, <c>false</c>.</returns>
-    public virtual bool Equals(in Color color, object? obj)
-    {
-        if (obj is not Color color2) return false;
-
-        return color.A.EqualsInTolerance(color2.A) 
-            && color.R.EqualsInTolerance(color2.R) 
-            && color.G.EqualsInTolerance(color2.G) 
-            && color.B.EqualsInTolerance(color2.B);
-    }
+    public bool Equals(in Color color, object? obj) => obj is Color color2 && Equals(color, color2);
+
+    /// <summary>
+    /// Tests whether the specified object is a <see cref="Color" /> and is equivalent to this <see cref="Color" />.
+    /// </summary>
+    /// <param name="color">The first color to test.</param>
+    /// <param name="color2">The second color to test.</param>
+    /// <returns><c>true</c> if <paramref name="color2" /> equivalent to this <see cref="Color" />; otherwise, <c>false</c>.</returns>
+    public bool Equals(in Color color, in Color color2) => color.A.EqualsInTolerance(color2.A)
+                                                        && color.R.EqualsInTolerance(color2.R)
+                                                        && color.G.EqualsInTolerance(color2.G)
+                                                        && color.B.EqualsInTolerance(color2.B);
 
     /// <summary>
     /// Returns a hash code for this <see cref="Color" />.
     /// </summary>
     /// <returns>An integer value that specifies the hash code for this <see cref="Color" />.</returns>
-    public virtual int GetHashCode(in Color color) => HashCode.Combine(color.A, color.R, color.G, color.B);
+    public int GetHashCode(in Color color) => HashCode.Combine(color.A, color.R, color.G, color.B);
 
     /// <summary>
     /// Blends a <see cref="Color"/> over this color.
     /// </summary>
     /// <param name="baseColor">The <see cref="Color"/> to to blend over.</param>
     /// <param name="blendColor">The <see cref="Color"/> to blend.</param>
-    public virtual Color Blend(in Color baseColor, in Color blendColor)
+    public Color Blend(in Color baseColor, in Color blendColor)
     {
         if (blendColor.A.EqualsInTolerance(0)) return baseColor;
 

RGB.NET.Core/Color/Behaviors/IColorBehavior.cs

@@ -20,6 +20,14 @@ public interface IColorBehavior
     /// <returns><c>true</c> if <paramref name="obj" /> is a <see cref="Color" /> equivalent to this <see cref="Color" />; otherwise, <c>false</c>.</returns>
     bool Equals(in Color color, object? obj);
 
+    /// <summary>
+    /// Tests whether the specified object is a <see cref="Color" /> and is equivalent to this <see cref="Color" />.
+    /// </summary>
+    /// <param name="color">The first color to test.</param>
+    /// <param name="color2">The second color to test.</param>
+    /// <returns><c>true</c> if <paramref name="color2" /> equivalent to this <see cref="Color" />; otherwise, <c>false</c>.</returns>
+    bool Equals(in Color color, in Color color2);
+
     /// <summary>
     /// Returns a hash code for this <see cref="Color" />.
     /// </summary>

RGB.NET.Core/Color/Color.cs

@@ -11,7 +11,7 @@ namespace RGB.NET.Core;
 /// Represents an ARGB (alpha, red, green, blue) color.
 /// </summary>
 [DebuggerDisplay("[A: {A}, R: {R}, G: {G}, B: {B}]")]
-public readonly struct Color
+public readonly struct Color : IEquatable<Color>
 {
     #region Constants
 
@@ -196,6 +196,13 @@ public Color(in Color color)
     /// <returns><c>true</c> if <paramref name="obj" /> is a <see cref="Color" /> equivalent to this <see cref="Color" />; otherwise, <c>false</c>.</returns>
     public override bool Equals(object? obj) => Behavior.Equals(this, obj);
 
+    /// <summary>
+    /// Tests whether the specified <see cref="Color" /> is equivalent to this <see cref="Color" />, as defined by the current <see cref="Behavior"/>.
+    /// </summary>
+    /// <param name="other">The color to test.</param>
+    /// <returns><c>true</c> if <paramref name="other" /> is equivalent to this <see cref="Color" />; otherwise, <c>false</c>.</returns>
+    public bool Equals(Color other) => Behavior.Equals(this, other);
+
     /// <summary>
     /// Returns a hash code for this <see cref="Color" />, as defined by the current <see cref="Behavior"/>.
     /// </summary>

RGB.NET.Core/Decorators/AbstractDecorateable.cs

@@ -11,7 +11,7 @@ public abstract class AbstractDecoratable<T> : AbstractBindable, IDecoratable<T>
 {
     #region Properties & Fields
 
-    private readonly List<T> _decorators = new();
+    private readonly List<T> _decorators = [];
 
     /// <inheritdoc />
     public IReadOnlyList<T> Decorators { get; }

RGB.NET.Core/Decorators/AbstractDecorator.cs

@@ -29,7 +29,7 @@ public int Order
     /// <summary>
     /// Gets a readonly-list of all <see cref="IDecoratable"/> this decorator is attached to.
     /// </summary>
-    protected List<IDecoratable> DecoratedObjects { get; } = new();
+    protected List<IDecoratable> DecoratedObjects { get; } = [];
 
     #endregion
 
@@ -46,14 +46,14 @@ public int Order
     /// </summary>
     protected virtual void Detach()
     {
-        List<IDecoratable> decoratables = new(DecoratedObjects);
+        List<IDecoratable> decoratables = [..DecoratedObjects];
         foreach (IDecoratable decoratable in decoratables)
         {
             IEnumerable<Type> types = decoratable.GetType().GetInterfaces().Where(t => t.IsGenericType
                                                                                     && (t.Name == typeof(IDecoratable<>).Name)
                                                                                     && t.GenericTypeArguments[0].IsInstanceOfType(this));
             foreach (Type decoratableType in types)
-                decoratableType.GetMethod(nameof(IDecoratable<IDecorator>.RemoveDecorator))?.Invoke(decoratable, new object[] { this });
+                decoratableType.GetMethod(nameof(IDecoratable<IDecorator>.RemoveDecorator))?.Invoke(decoratable, [this]);
         }
     }
 

RGB.NET.Core/Decorators/IDecoratable.cs

@@ -6,8 +6,7 @@ namespace RGB.NET.Core;
 /// <summary>
 /// Represents a basic decoratable.
 /// </summary>
-public interface IDecoratable : INotifyPropertyChanged
-{ }
+public interface IDecoratable : INotifyPropertyChanged;
 
 /// <inheritdoc />
 /// <summary>

RGB.NET.Core/Decorators/ILedGroupDecorator.cs

@@ -4,5 +4,4 @@
 /// <summary>
 /// Represents a basic decorator decorating a <see cref="T:RGB.NET.Core.ILedGroup" />.
 /// </summary>
-public interface ILedGroupDecorator : IDecorator
-{ }
+public interface ILedGroupDecorator : IDecorator;