Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to get building under linux. #44

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

gnac
Copy link

@gnac gnac commented Jul 25, 2023

CMakeLists.txt added a linux section. By default the libonnxruntime-neuralnote for linux builds a shared library, but the linux branch of the gnac fork also creates a combined static library. Both of these are, at the moment causing linker errors.

build.sh added a linux section. This uses the default v1.14.1-neuralnote.0 libonnxruntime archive when manually building the libonnxruntime library per its readme's make-archive script directions.

Added #include to Lib/Model/Notes.cpp because the Linux c++ compiler was complaining about undefined assert().

Added Linux build instructions to Readme.md along with information about current build errors.

CMakeLists.txt added a linux section.  By default the libonnxruntime-neuralnote for linux builds a shared library, but
the linux branch of the [gnac fork](https://github.com/gnac/libonnxruntime-neuralnote) also creates a combined static library.
Both of these are, at the moment causing linker errors.
build.sh added a linux section.  This uses the default v1.14.1-neuralnote.0 libonnxruntime archive when manually building the libonnxruntime library per its readme's make-archive script directions.
Added #include <cassert> to Lib/Model/Notes.cpp because the Linux c++ compiler was complaining about undefined assert()
Added Linux build instructions to Readme.md along with information about current build errors.
@gnac gnac mentioned this pull request Jul 25, 2023
@DamRsn
Copy link
Owner

DamRsn commented Jul 25, 2023

Thanks for contributing!

Before merging, it'd be great to fix the linker error and have everything working. I'm converting the PR to draft.

I'll give it a shot when I have some time!

@DamRsn DamRsn marked this pull request as draft July 25, 2023 21:55
@gnac
Copy link
Author

gnac commented Jul 25, 2023

Before merging, it'd be great to fix the linker error and have everything working. I'm converting the PR to draft.

Yeah, I'm kind of stuck on that at the moment. Originally I had tried with the shared library built by default with the libonnxruntime library, but that caused a specific error in one file, probably because we are linking a static library against the shared, so I tried building a "combined" static library like the macos version of libonnx does, but that just caused even more linker errors. It could be that the static library in linux isn't really adding the necessary sublibraries/symbols, so there are more errors generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants