feat: add review item responsive and color #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yolophg
force-pushed
the
helena/55-make-reveiw-item-responsive
branch
from
90dc27d
to
fdf9a80
Compare
DaleSeo
reviewed
Jun 25, 2024
components/review-item.js
Outdated
Comment on lines
7
to
10
| connectedCallback() { | ||
| this.attachShadow({ mode: "open" }); | ||
| this.render(); | ||
| } |
There was a problem hiding this comment.
이 패턴은 쓰지 않기로 한 것 같은데, 아직 작업 중이신거죠? 아직 PR이 Ready for review가 아니시라면 Draft 상태로 변경해주시면 혼선이 적을 것 같습니다!
There was a problem hiding this comment.
@DaleSeo
아, 이 pr이 저희 이번에 결정나기 전에 지난 이터레이션에 올렸던 review item의 responsive pr이었는데, 지금까지 approve가 안되어서 혼선을 드린 것 같습니다!!
이런 경우에는, 제가 draft로 돌리고 이번에 바뀐 패턴으로 적용해서 pr을 올리는게 나을까요?
어차피 지금 하고 있는 step 컴포넌트 작업이 끝나면 review item 부터 바뀐 패턴으로 수정하려던 참이었거든요!
There was a problem hiding this comment.
바뀐 컴포넌트 패턴으로 변경 완료하였습니다! 컬러까지 적용할 예정이어서, draft로 돌린 점도 참고 부탁드립니다!
yolophg
changed the title
|
color 까지 적용완료 되었습니다. |
sounmind
reviewed
Jun 26, 2024
sounmind
reviewed
Jun 26, 2024
sounmind
reviewed
Jun 26, 2024
sounmind
reviewed
Jun 26, 2024
sounmind
reviewed
Jun 26, 2024
sounmind
reviewed
Jun 26, 2024
|
리뷰를 반영하여, 불필요한 미디어쿼리 삭제 및 네이밍 업데이트 완료하였습니다. |
sounmind
reviewed
Jun 26, 2024
sounmind
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before merging