-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : implemented header component #32
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2db6a46
feat : implemented header component except for buttons for future int…
SamTheKorean 1851851
feat : completely integrated link-button component into header component
SamTheKorean 66f9849
modify border-bottom css to use var(--border)
SamTheKorean 32ec7fa
fix : apply feedback in pull request
SamTheKorean File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
import "./link-button/link-button.js"; | ||
|
||
const template = document.createElement("template"); | ||
template.innerHTML = ` | ||
<style> | ||
:host { | ||
position: fixed; | ||
top: 0; | ||
left: 0; | ||
padding: 20px 0; | ||
width: 100%; | ||
border-bottom: 1px solid #D3D3D3; | ||
background-color: rgba(255, 255, 255, 0.8); | ||
} | ||
|
||
header { | ||
width: 80%; | ||
margin: 0 auto; | ||
justify-content: space-between; | ||
display: flex; | ||
align-items: center; | ||
} | ||
|
||
.buttons-container { | ||
display: flex; | ||
} | ||
|
||
a { | ||
display: flex; | ||
gap: 10px; | ||
align-items: center; | ||
text-decoration: none; | ||
} | ||
|
||
a img { | ||
width: 45px; | ||
height: 22.5px; | ||
} | ||
|
||
a span { | ||
font-size: 20px; | ||
font-weight: 500; | ||
color: black; | ||
} | ||
</style> | ||
<header> | ||
<a href="/"> | ||
<img src="images/logo.png" alt="logo" /> | ||
<span>달레 스터디</span> | ||
</a> | ||
|
||
<div class="buttons-container"> | ||
<link-button href="#join-instruction-container" size="large" variant="primary">참여방법 안내</link-button> | ||
<link-button href="https://discord.gg/43UkheRV" size="large" variant="secondary">디스코드 참여하기</link-button> | ||
</div> | ||
</header> | ||
`; | ||
|
||
class HeaderComponent extends HTMLElement { | ||
constructor() { | ||
super(); | ||
this.attachShadow({ mode: "open" }); | ||
this.shadowRoot.appendChild(template.content.cloneNode(true)); | ||
} | ||
} | ||
|
||
customElements.define("header-component", HeaderComponent); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
import "./components/divider/divider.js"; | ||
import "./components/footer-link/footer-link.js"; | ||
import "./components/header.js" | ||
import "./components/hero/hero.js"; | ||
import "./components/link-button/link-button.js"; | ||
import "./components/seo-meta-tag/seo-meta-tag.js"; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이렇게 자바스크립트 파일 하나로 뽑아내니, 생각했던 것보다 더 심플하고 좋은데요? At least, for me lol