Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS clean up/simplification #153

Merged
merged 2 commits into from
Jul 16, 2024
Merged

CSS clean up/simplification #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89d78ca
chore: remove unused styles
sounmind Jul 16, 2024
bc6afab
style: update global styles
sounmind Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions components/footer-link-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,6 @@ class FooterLinks extends HTMLElement {

createCss() {
return css`
ul {
padding: 0;
margin: 0;
list-style-type: none;
}

ul {
display: flex;
flex-direction: column;
Expand Down Expand Up @@ -89,9 +83,6 @@ class FooterLink extends HTMLElement {
createCss() {
return css`
li {
padding: 0;
margin: 0;
list-style-type: none;
color: var(--bg-100);
font-size: 16px;
}
Expand Down
5 changes: 0 additions & 5 deletions components/step.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,6 @@ class Step extends BaseStepElement {

createCss() {
return css`
h3,
::slotted(p) {
margin: 0;
padding: 0;
}
article {
width: 100%;
height: 400px;
Expand Down
10 changes: 9 additions & 1 deletion global-styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,15 @@ h2,
h3,
h4,
h5,
h6 {
h6,
ol,
ul,
li {
margin: 0;
padding: 0;
}

ol,
ul {
list-style-type: none;
}
101 changes: 0 additions & 101 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,107 +37,6 @@

<script src="https://code.iconify.design/iconify-icon/2.1.0/iconify-icon.min.js"></script>
<script src="./main.js" async defer type="module"></script>

<style>
header {
margin: 2rem 0;
border-bottom: 0.1rem solid #d3d3d3;
padding-bottom: 1rem;
display: flex;
justify-content: space-between;
}

header img {
width: 4rem;
height: 2rem;
}

header span {
font-size: 2rem;
margin-left: 1rem;
}

header img,
span {
vertical-align: middle;
}

.hero {
width: 32%;
font-size: 5rem;
font-weight: medium;
}

#language-container {
display: flex;
justify-content: space-between;
margin-top: 23.5rem;
padding-bottom: 24rem;
border-bottom: 0.1rem solid #d3d3d3;
}

.language-image {
width: 40%;
}

.language-image img {
max-width: 100%;
}

#review-container {
display: flex;
justify-content: space-between;
margin-top: 23.5rem;
padding-bottom: 24rem;
border-bottom: 0.1rem solid #d3d3d3;
}

.review-image {
width: 60%;
}

.review-image img {
max-width: 100%;
}

#member-review-container {
margin-top: 15rem;
padding-bottom: 15rem;
border-bottom: 0.1rem solid #d3d3d3;
}

.member-review-card {
display: flex;
justify-content: space-between;
width: 49%;
}

#member-review-container > span {
font-size: 5rem;
font-weight: medium;
}

/* 'review-card-list' style will be removed when the review card list component is created */
.review-card-list {
display: grid;
grid-template-columns: minmax(306px, 1fr);
gap: 10px;
padding-top: 40px;
place-content: center;
place-items: center;
}

#join-instruction-container {
margin-top: 15rem;
padding-bottom: 15rem;
border-bottom: 0.1rem solid #d3d3d3;
}

#join-instruction-container > span {
font-size: 5rem;
font-weight: medium;
}
</style>
</head>

<body>
Expand Down