Skip to content

Commit

Permalink
fix : apply feedback in pull request
Browse files Browse the repository at this point in the history
  • Loading branch information
SamTheKorean committed Jun 13, 2024
1 parent 66f9849 commit 2c8cd87
Show file tree
Hide file tree
Showing 4 changed files with 74 additions and 78 deletions.
72 changes: 72 additions & 0 deletions components/header.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
import "./link-button/link-button.js";

const template = document.createElement("template");
template.innerHTML = `
<style>
:host {
position: fixed;
top: 0;
left: 0;
padding: 20px 0;
width: 100%;
border-bottom: 1px solid #D3D3D3;
background-color: rgba(255, 255, 255, 0.8);
}
header {
width: 80%;
margin: 0 auto;
justify-content: space-between;
display: flex;
align-items: center;
}
.buttons-container {
display: flex;
}
.logo {
display: flex;
gap: 10px;
align-items: center;
text-decoration: none;
}
.logo img {
width: 45px;
height: 22.5px;
}
.logo span {
font-size: 20px;
font-weight: 500;
color: black;
}
.logo img,
.logo span {
vertical-align: middle;
}
</style>
<header>
<a href="#" class="logo">
<img src="images/logo.png" alt="logo" />
<span>달레 스터디</span>
</a>
<div class="buttons-container">
<link-button href="#join-instruction-container" size="large" variant="primary">참여방법 안내</link-button>
<link-button href="https://discord.gg/43UkheRV" size="large" variant="secondary">디스코드 참여하기</link-button>
</div>
</header>
`;

class HeaderComponent extends HTMLElement {
constructor() {
super();
this.attachShadow({ mode: "open" });
this.shadowRoot.appendChild(template.content.cloneNode(true));
}
}

customElements.define("header-component", HeaderComponent);
49 changes: 0 additions & 49 deletions components/header/header.css

This file was deleted.

28 changes: 0 additions & 28 deletions components/header/header.js

This file was deleted.

3 changes: 2 additions & 1 deletion main.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import "./components/divider/divider.js";
import "./components/footer-link/footer-link.js";
import "./components/header.js"
import "./components/hero/hero.js";
import "./components/link-button/link-button.js";
import "./components/seo-meta-tag/seo-meta-tag.js";
import "./components/header/header.js"

0 comments on commit 2c8cd87

Please sign in to comment.