[환미니니] Week7 문제풀이 #490
Merged
[환미니니] Week7 문제풀이 #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HC-kang
approved these changes
Sep 29, 2024
| const que = [[row,col]] | ||
|
|
||
| while (que.length) { | ||
| const [row, col] = que.pop() |
There was a problem hiding this comment.
이 부분을 볼때, 이름과 동작이 맞지 않는것같아요
queue를 의도하신것같은데, 실제 동작은 stack으로 하고있는 것 같습니다.
결과적으로 bfs라는 함수도 dfs로 동작하고있는것으로 보여요
There was a problem hiding this comment.
shift로 했을 때 시간이 초과되어서 pop을 사용해서 풀었는데
다시 풀어봐야겠어요!
| let leftIdx = 0; | ||
| for (let rightIdx = 0 ; rightIdx < s.length; rightIdx++) { | ||
| const char = s[rightIdx] | ||
| if (map.has(char) && map.get(char) >= leftIdx) leftIdx = map.get(char) + 1; |
There was a problem hiding this comment.
중요하지 않은 가독성 관련 의견입니다! 무시하셔도 좋습니다!
이 부분은 핵심 변수인 leftIdx가 변동되는 굉장히 중요한 부분인데, 길게 원라인으로 되어있어 다른 개발자가 읽기 다소 어렵지 않을까 하는 의견입니다!
naringst
reviewed
Sep 29, 2024
| const isValidMove = (grid, n_row, n_col) => { | ||
| return n_row >= 0 && n_row < grid.length && n_col >= 0 && n_col < grid[0].length && grid[n_row][n_col] !== '0' | ||
| } | ||
|
|
There was a problem hiding this comment.
이렇게 함수를 따로 빼셔서 코드가 엄청 깔끔해진 것 같네요! 저도 다음에 활용해보고 싶네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.