[재호] WEEK 07 Solutions #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HC-kang
approved these changes
Sep 28, 2024
| @@ -0,0 +1,69 @@ | |||
| /** | |||
| * 2차 | |||
| * Tony님 풀이 참고해서 SC 개선 | |||
set-matrix-zeroes/wogha95.js
Outdated
| } | ||
|
|
||
| // 3. 특정 좌표의 가로, 세로를 char문자로 변경 (대신 0인 요소는 변경하지 않음) | ||
| function changeToChar(row, column, char) { |
There was a problem hiding this comment.
중요한 쟁점은 아니지만, char를 굳이 파라미터로 넘기신 이유가 있으실까요?
ROW, COLUMN 처럼 함수 내 전역으로 사용한다면 더 통일감있지 않았을까 하는 생각이 들어서요.
There was a problem hiding this comment.
Mark 상수 만들어 코드 개선하였습니다!
리뷰 감사합니다~!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.