Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] 공지사항 상세조회 기능 구현 #73

Merged
merged 7 commits into from
Sep 15, 2023

Conversation

pdohyung
Copy link
Member

💡 연관된 이슈

close #72

📝 작업 내용

공지사항 상세조회 기능 구현

💬 리뷰 요구 사항

@pdohyung pdohyung added the ✨ Feature 기능 개발 label Sep 15, 2023
@pdohyung pdohyung linked an issue Sep 15, 2023 that may be closed by this pull request
Copy link
Member

@kyeong-hyeok kyeong-hyeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승인합니다. 이후 리팩토링 진행하시죠


NoticeGetResponseDto response = NoticeGetResponseDto.from(notice);
return response;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공지사항 상세 조회에서 이전글이랑 다음글의 카테고리, 제목, 날짜 불러와야 해서 그 부분 수정하고 Dto 새로 만들어야 할 듯합니다.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Query("SELECT n FROM Notice n WHERE n.id < :noticeId ORDER BY n.id DESC LIMIT 1")
Notice findPreviousNotice(@Param("noticeId") Long noticeId);
@Query("SELECT n FROM Notice n WHERE n.id > :noticeId ORDER BY n.id LIMIT 1")
Notice findNextNotice(@Param("noticeId") Long noticeId);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 바꿨네 좋아좋아 굿

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿 굿

@pdohyung pdohyung merged commit 538fa93 into develop Sep 15, 2023
1 check passed
@pdohyung pdohyung deleted the feature/72-notice-detail-get branch September 15, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] 공지사항 상세조회 기능 구현
2 participants