Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] FAQ 생성 기능 구현 #36

Merged
merged 4 commits into from
Sep 8, 2023
Merged

[Feature] FAQ 생성 기능 구현 #36

merged 4 commits into from
Sep 8, 2023

Conversation

kyeong-hyeok
Copy link
Member

💡 연관된 이슈

close #35

📝 작업 내용

  • FAQ 생성 기능 구현
  • Valid에 대한 Exception 처리 -> ExceptionHandler에 MethodArgumentNotValidException 예외 처리 추가

💬 리뷰 요구 사항

@kyeong-hyeok kyeong-hyeok added the ✨ Feature 기능 개발 label Sep 8, 2023
@kyeong-hyeok kyeong-hyeok linked an issue Sep 8, 2023 that may be closed by this pull request
[Feature] FAQ 생성 기능 구현 #35
Closed
4 tasks
pdohyung
pdohyung approved these changes Sep 8, 2023
View reviewed changes
src/main/java/com/teamA/hicardi/domain/faq/controller/FaqController.java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요.

src/main/java/com/teamA/hicardi/domain/faq/dto/request/FaqSaveRequestDto.java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다.

src/test/java/com/teamA/hicardi/domain/faq/controller/FaqControllerTest.java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿 !

@pdohyung pdohyung merged commit 5465ac2 into develop Sep 8, 2023
1 check passed
@pdohyung pdohyung deleted the feature/35-faq-add branch September 8, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdohyung pdohyung pdohyung approved these changes

Assignees
No one assigned
Labels
✨ Feature 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] FAQ 생성 기능 구현
2 participants
@kyeong-hyeok @pdohyung