[Refactor] 장바구니 상품 추가 Dto 클래스 타입 record로 변경 및 ErrorCode 추가 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kyeong-hyeok
reviewed
Sep 8, 2023
| @@ -24,7 +22,6 @@ public class CartController { | |||
| private final CartService cartService; | |||
|
|
|||
| @PostMapping("/add") | |||
| @ResponseStatus(HttpStatus.NO_CONTENT) | |||
| @@ -37,7 +39,7 @@ public class CartService { | |||
| public void addCartItem(CartItemAddRequestDto cartItemAddRequestDto, String userId) { | |||
|
|
|||
| Member findMember = memberRepository.findByUserId(userId) | |||
| .orElseThrow(() -> new IllegalArgumentException("존재하지 않는 회원입니다.")); | |||
| .orElseThrow(() -> new BusinessException(ErrorCode.MEMBER_NOT_FOUND)); | |||
| @@ -53,16 +55,11 @@ public void addCartItem(CartItemAddRequestDto cartItemAddRequestDto, String user | |||
|
|
|||
| // 해당 회원의 장바구니를 가져와서 상품을 추가 | |||
| Cart findCart = cartRepository.findCartByMember_Id(memberId) | |||
There was a problem hiding this comment.
현재 설정은 PhysicalNamingStrategyStandardImpl 이거라 Repository 메서드도 findByMemberId로 바꾸면 될 듯!? 크게 상관은 없긴 하지만 통일한다면~~
(참고)
SpringPhysicalNamingStrategy(Default)
-> camel case를 underscore 형태로 변경
PhysicalNamingStrategyStandardImpl
-> 변수 이름을 그대로 사용
| .cart(cart) | ||
| .item(item) | ||
| .count(count) | ||
| .build(); |
kyeong-hyeok
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 연관된 이슈
close #23
📝 작업 내용
💬 리뷰 요구 사항