-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vitalium: Use SVG Logo #117
Conversation
does that mean the logo gets colorized too? I sadly dont have automated tests in place, cant check here yet if the build is all ok. |
It does. Themes can override it too. |
nice, super cool! thanks for the effort! will try to give this some attention next week. |
@falkTX is there any chance you can get around to reviewing this one soon. |
Will this ever get reviewed? Its been a few months now. |
give it time. life happens and people get busy. I thought I would be able to handle vitalium stuff in March/April, but sadly it is going to need some time. I will come back to this eventually |
@falkTX Would be awesome to see Vitalium become it's own project with it own presets etc. Also to note that Vital newer versions dropped lv2 support. |
699985d
to
e6b52f0
Compare
a079e33
to
cefa148
Compare
267a903
to
af10d1a
Compare
nice to rebase against latest master, please do it again :) I did not notice GH actions were only set for commits, not PRs |
closes #103
Alright now everything is in place, and no build issues at least. I decided to keep vitalium in distrho-ports, if that was not obvious yet. Since JUCE has breaking changes regularly, it is best for us to keep compat with each minor version anyway, as that will make it easier to (im)port other plugins. |
and of course, thanks! |
Took almost a year but im glad it finally made it in. :) |
It still needs a release, but now the automated builds help in the mean time. |
@DarkRTA Thanks for recreating the vectors! |
This replaces the
.png
currently in use with a hand drawn.svg
. The.svg
was produced by auto-tracing the logo in Inkscape, followed by manually cleaning it up.The code was done by reverting the commit which introduced the
.png
in the first place, and cleaning up anything that was broken by doing so.Closes #103.