Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vitalium: Use SVG Logo #117

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Vitalium: Use SVG Logo #117

merged 1 commit into from
Dec 11, 2023

Conversation

DarkRTA
Copy link
Contributor

@DarkRTA DarkRTA commented Jan 15, 2023

This replaces the .png currently in use with a hand drawn .svg. The .svg was produced by auto-tracing the logo in Inkscape, followed by manually cleaning it up.

The code was done by reverting the commit which introduced the .png in the first place, and cleaning up anything that was broken by doing so.

Closes #103.

@falkTX
Copy link
Contributor

falkTX commented Jan 15, 2023

does that mean the logo gets colorized too?

I sadly dont have automated tests in place, cant check here yet if the build is all ok.
So will do some testing only later next week.

@DarkRTA
Copy link
Contributor Author

DarkRTA commented Jan 15, 2023

does that mean the logo gets colorized too?

It does. Themes can override it too.

@falkTX
Copy link
Contributor

falkTX commented Jan 15, 2023

nice, super cool! thanks for the effort!

will try to give this some attention next week.

@DarkRTA
Copy link
Contributor Author

DarkRTA commented Jan 22, 2023

@falkTX is there any chance you can get around to reviewing this one soon.

@DarkRTA
Copy link
Contributor Author

DarkRTA commented Apr 15, 2023

Will this ever get reviewed? Its been a few months now.

@falkTX
Copy link
Contributor

falkTX commented Apr 15, 2023

give it time. life happens and people get busy.

I thought I would be able to handle vitalium stuff in March/April, but sadly it is going to need some time.
I updated this repo to use JUCE 6.1 instead of 6.0.
Thing is, while Vitalium works in JUCE 6.0 it looks totally wrong in JUCE 6.1.
So very likely i will need to take vitalium from the DISTRHO-Ports project and make it a standalone project, or try to fix the graphical issues myself.
Matt, the original Vital author, has ignored my questions for why things got broken, so we are on our own for figuring this out.

I will come back to this eventually

@nyabinary
Copy link

nyabinary commented Aug 9, 2023

@falkTX Would be awesome to see Vitalium become it's own project with it own presets etc. Also to note that Vital newer versions dropped lv2 support.

@falkTX falkTX force-pushed the master branch 9 times, most recently from 699985d to e6b52f0 Compare November 26, 2023 16:02
@falkTX falkTX force-pushed the master branch 14 times, most recently from a079e33 to cefa148 Compare December 9, 2023 12:02
@falkTX falkTX force-pushed the master branch 9 times, most recently from 267a903 to af10d1a Compare December 10, 2023 13:13
@falkTX
Copy link
Contributor

falkTX commented Dec 10, 2023

nice to rebase against latest master, please do it again :) I did not notice GH actions were only set for commits, not PRs

@falkTX
Copy link
Contributor

falkTX commented Dec 11, 2023

Alright now everything is in place, and no build issues at least.

I decided to keep vitalium in distrho-ports, if that was not obvious yet. Since JUCE has breaking changes regularly, it is best for us to keep compat with each minor version anyway, as that will make it easier to (im)port other plugins.

@falkTX falkTX merged commit 51eb55f into DISTRHO:master Dec 11, 2023
15 checks passed
@falkTX
Copy link
Contributor

falkTX commented Dec 11, 2023

and of course, thanks!

@DarkRTA
Copy link
Contributor Author

DarkRTA commented Dec 11, 2023

Took almost a year but im glad it finally made it in. :)

@falkTX
Copy link
Contributor

falkTX commented Dec 11, 2023

It still needs a release, but now the automated builds help in the mean time.

@unfa
Copy link

unfa commented Dec 11, 2023

@DarkRTA Thanks for recreating the vectors!

@DarkRTA DarkRTA deleted the vitalium-svg branch December 12, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better rendering of Vitalium's logo
4 participants