[v8.0] fix (StompMQConnector): add a timeout for the StompConnector #7854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIRACGridBot
added
the
alsoTargeting:integration
chrisburr
reviewed
Oct 24, 2024
| @@ -83,6 +86,7 @@ def setupConnection(self, parameters=None): | |||
| connectionArgs = { | |||
| "vhost": vhost, | |||
| "keepalive": True, | |||
| "timeout": stompTimeout, | |||
There was a problem hiding this comment.
Having tried it we also need something like "heartbeats": (outgoingHeartbeatMs, incomingHeartbeatMs), here as well. 15_000 seems like a sensible default
|
I think the logic also needs fixing to close the connection if it's still open. |
It doesn't close by itself on timeout? |
I wouldn't expect it to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @chrisburr
for #7851
BEGINRELEASENOTES
*StompMQConnector
FIX: add a timeout for the StompConnector to handle nonresponsive sockets which can cause logging to be blocked
ENDRELEASENOTES