[v8.0] feat (TS): add getTransformationFilesAsJsonString #7840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIRACGridBot
added
the
alsoTargeting:integration
andresailer
reviewed
Oct 16, 2024
src/DIRAC/TransformationSystem/Service/TransformationManagerHandler.py
Outdated
Show resolved
Hide resolved
fstagni
reviewed
Oct 16, 2024
| @@ -603,6 +603,7 @@ def getTransformationFiles( | |||
| offset=None, | |||
| connection=False, | |||
| columns=None, | |||
| include_web_records=True, | |||
There was a problem hiding this comment.
I would reverse this flag, and make a tiny WebApp patch.
There was a problem hiding this comment.
We suspect it isn't used at all. The idea would be to switch it back in v9 but it's a nasty backwards incompatible change in a patch release if anyone does happen to be using it.
fstagni
reviewed
Oct 16, 2024
| DEncode cannot cope with nested structures of multiple millions items. | ||
| Encode everything as a json string, that DEncode cna then transmit faster. | ||
|
|
||
| This will be the default as of v9.0 |
There was a problem hiding this comment.
Then you should add a deprecation notice for export_getTransformationFiles
There was a problem hiding this comment.
We were thinking we would keep getTransformationFiles and deprecate getTransformationFilesAsJson in v9.
chrisburr
changed the title
chrisburr
changed the title
chrisburr
changed the title
chrisburr
changed the title
fstagni
approved these changes
Oct 17, 2024
DIRACGridBot
added
the
sweep:done
DIRACGridBot
pushed a commit
to DIRACGridBot/DIRAC
that referenced
this pull request
Oct 17, 2024
|
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/11384174344 Successful:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
*Core
FIX: Returning DISET responses with >100000000 bytes
*Transformation
NEW: Use getTransformationFilesAsJsonString for faster getTransformationFiles
ENDRELEASENOTES