Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Drop CloudCE proxy handling #7823

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

sfayer
Copy link
Member

@sfayer sfayer commented Oct 10, 2024

Hi,

Now that the pilot wrapper always includes a bundled proxy, we don't need to handle writing one specially in the cloud scripts, so this patch drops all of that functionality. This also fixes a recent v8 bug where CloudCE keeps self.proxy in a different format (string rather than proxy object) to other CEs resulting in a SiteDirector crash.

[Note: Users with a custom cloudinit.template will need to update it to match these changes].

Regards,
Simon

BEGINRELEASENOTES
*Resources
FIX: Drop CloudCE proxy handling
ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Oct 10, 2024
@chrisburr chrisburr merged commit 7e453ce into DIRACGrid:rel-v8r0 Oct 11, 2024
26 checks passed
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Oct 11, 2024
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/11300362440

Failed:

  • integration
    cherry-pick 7e453ce into integration failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-7e453ce0f-integration
    git cherry-pick -x -m 1 7e453ce0f
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #7823 Drop CloudCE proxy handling' --author='Simon Fayer <[email protected]>'
    git push -u origin cherry-pick-2-7e453ce0f-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] Drop CloudCE proxy handling' \
         --body 'Sweep #7823 `Drop CloudCE proxy handling` to `integration`.
    
    Adding original author @sfayer as watcher.
    
    BEGINRELEASENOTES
    *Resources
    FIX: Drop CloudCE proxy handling
    ENDRELEASENOTES
    Closes #7828'

sfayer added a commit to sfayer/DIRAC that referenced this pull request Oct 12, 2024
sfayer added a commit to sfayer/DIRAC that referenced this pull request Oct 12, 2024
sfayer added a commit to sfayer/DIRAC that referenced this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants