Fix potential memory leaks by confining use of pyvips to subprocesses #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did a few spot-checks regarding wait times and error propagation behavior... seems to be alright. |
pkcakeout
changed the title
pkcakeout
changed the title
|
I couldn't remove openslide with confidence so gave up on that and moved the converter passing removal here. |
jmsmkn
approved these changes
Jan 23, 2025
Had the same issue. I also was not comfortable with modifying the tests to the extent you did, so thanks for picking that up! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to
libvipsthat cause errors are suspected to cause memory leaks in libvips. In order to prevent this, this PR confines calls to pyvips to subprocesses spawned usingProcessPoolExecutor.