Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flake8 to 7.0.0 #68

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Update flake8 to 7.0.0 #68

merged 1 commit into from
Apr 26, 2024

Conversation

mintar
Copy link
Member

@mintar mintar commented Apr 26, 2024

This fixes the following wrong error messages:

rclpy_message_converter/test/test_json_message_converter.py:84:-1: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:85:20: E202 whitespace before '}'
rclpy_message_converter/test/test_json_message_converter.py:86:-1: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:87:-1: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:89:61: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:90:61: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:92:24: E202 whitespace before '}'
rclpy_message_converter/test/test_json_message_converter.py:93:-1: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:94:58: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:95:58: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:96:58: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:98:24: E202 whitespace before '}'
rclpy_message_converter/test/test_json_message_converter.py:99:20: E202 whitespace before '}'
rclpy_message_converter/test/test_json_message_converter.py:100:16: E202 whitespace before '}'
rclpy_message_converter/test/test_json_message_converter.py:102:-2: E202 whitespace before ']'
rclpy_message_converter/test/test_json_message_converter.py:102:8: E202 whitespace before '}'
rclpy_message_converter/test/test_json_message_converter.py:185:-1: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:186:20: E202 whitespace before '}'
rclpy_message_converter/test/test_json_message_converter.py:187:-1: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:188:-1: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:190:61: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:191:61: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:193:24: E202 whitespace before '}'
rclpy_message_converter/test/test_json_message_converter.py:194:-1: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:195:58: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:196:58: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:197:58: E231 missing whitespace after ','
rclpy_message_converter/test/test_json_message_converter.py:199:24: E202 whitespace before '}'
rclpy_message_converter/test/test_json_message_converter.py:200:20: E202 whitespace before '}'
rclpy_message_converter/test/test_json_message_converter.py:201:16: E202 whitespace before '}'
rclpy_message_converter/test/test_json_message_converter.py:203:-2: E202 whitespace before ']'
rclpy_message_converter/test/test_json_message_converter.py:203:8: E202 whitespace before '}'

This only happened in ROS2 rolling (python 3.12), not in Humble or Iron (python 3.10), both with flake8 3.7.9, 5.0.4 and 6.0.0. These are false alarms (flake8 doesn't recognize that these are multi-line json strings, not python source code).

This fixes the following wrong error messages:

    rclpy_message_converter/test/test_json_message_converter.py:84:-1: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:85:20: E202 whitespace before '}'
    rclpy_message_converter/test/test_json_message_converter.py:86:-1: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:87:-1: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:89:61: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:90:61: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:92:24: E202 whitespace before '}'
    rclpy_message_converter/test/test_json_message_converter.py:93:-1: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:94:58: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:95:58: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:96:58: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:98:24: E202 whitespace before '}'
    rclpy_message_converter/test/test_json_message_converter.py:99:20: E202 whitespace before '}'
    rclpy_message_converter/test/test_json_message_converter.py:100:16: E202 whitespace before '}'
    rclpy_message_converter/test/test_json_message_converter.py:102:-2: E202 whitespace before ']'
    rclpy_message_converter/test/test_json_message_converter.py:102:8: E202 whitespace before '}'
    rclpy_message_converter/test/test_json_message_converter.py:185:-1: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:186:20: E202 whitespace before '}'
    rclpy_message_converter/test/test_json_message_converter.py:187:-1: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:188:-1: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:190:61: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:191:61: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:193:24: E202 whitespace before '}'
    rclpy_message_converter/test/test_json_message_converter.py:194:-1: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:195:58: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:196:58: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:197:58: E231 missing whitespace after ','
    rclpy_message_converter/test/test_json_message_converter.py:199:24: E202 whitespace before '}'
    rclpy_message_converter/test/test_json_message_converter.py:200:20: E202 whitespace before '}'
    rclpy_message_converter/test/test_json_message_converter.py:201:16: E202 whitespace before '}'
    rclpy_message_converter/test/test_json_message_converter.py:203:-2: E202 whitespace before ']'
    rclpy_message_converter/test/test_json_message_converter.py:203:8: E202 whitespace before '}'

This only happened in ROS2 rolling (python 3.12), not in Humble or Iron
(python 3.10), both with flake8 3.7.9, 5.0.4 and 6.0.0. These are false
alarms (flake8 doesn't recognize that these are multi-line json strings,
not python source code).
@mintar mintar merged commit 0736c51 into DFKI-NI:rolling Apr 26, 2024
6 checks passed
@mintar mintar deleted the update-flake8 branch April 26, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant