-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified AutomataSUL file #55
Conversation
Will do quick round of testing tomorrow or today, check for potential places where it could break something, and run few tests... Will merge then. |
Tbh adding initial input in Moore-likes is counter-intuitive to me. Why? Plus then it makes something like zipping inputs and outputs harder, it is not consistent with Afaik AutomataLib form Learnlib does the same? |
I don't care too much as long as the behavior of SULs is consistent among Moore-like automata. So maybe it would be nice to adapt Martin's code to get a uniform interface. For now, I restored the original behavior (include initial output only for MDPs and MCs). One thing that's weird is that the I purged the aliases. |
…simplify_AutomataSUL
…ataSUL � Conflicts: � aalpy/SULs/AutomataSUL.py � aalpy/SULs/__init__.py � tests/test_deterministic.py
This gives a unified SUL for different Automaton types.
I also took the freedom to always include the initial output for automaton types that have an initial output (DFA, Moore, MC, MDP). If this inconsistency was on purpose I can match the original behavior.
I left the original classes as aliases to the unified SUL to avoid breakage for users. There are some internal uses which I'd like to purge.