add class Flame_1D and function fit_transport_data #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiweiqi
reviewed
Jul 10, 2020
| binary_diff_coeffs_list, binary_diff_coeffs_poly = binary_diff_coeffs(gas, T_list, p, comp) | ||
| thermal_conductivity_list, thermal_conductivity_poly = thermal_conductivity(gas, T_list, p, comp) | ||
|
|
||
| np.save('mech/transfit/species_viscosities_poly', species_viscosities_poly) |
There was a problem hiding this comment.
This is not urgent.
In the future, we can check whether the folder mech/transit exists. If it does not exist, we can then create one here.
jiweiqi
reviewed
Jul 10, 2020
| else: | ||
| self.device = device | ||
|
|
||
| self.tct = tct |
There was a problem hiding this comment.
This is also not urgent.
We can change .tct to .sol in this file, to better connect the name with the class Solution.
Ln 26/30/69-74/. You can simply replace all tct to sol in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.