Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BNGP-5494: Fix accessibility error for login/sign-in bar #895

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

BNGP-5494: Fix accessibility error for login/sign-in bar #895

wants to merge 3 commits into from

Conversation

StuAA78
Copy link
Collaborator

@StuAA78 StuAA78 commented Oct 9, 2024 •
edited
Loading

https://eaflood.atlassian.net/browse/BNGP-5494

The login/sign-in bar gives an accessibility error due to a lack of landmark. We fix this by changing the div containing it to a nav element.

@StuAA78 StuAA78 self-assigned this Oct 9, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@StuAA78 StuAA78 marked this pull request as ready for review October 9, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thousand-leaves thousand-leaves thousand-leaves approved these changes

Assignees

@StuAA78 StuAA78

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StuAA78 @thousand-leaves