Feature/profile image #47

leesa-l · 2024-10-03T08:21:01Z

프로필 이미지 수정 기능 추가

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Parameter should start on a newline

Chevit-Android/domain/src/main/java/com/dkin/chevit/domain/repository/AuthRepository.kt

Line 21 in 14871b1

    
           suspend fun uploadProfileImage(uploadURL: String, uploadMethod: String, uploadHeaders: String, file: File)

🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Parameter should start on a newline

Chevit-Android/domain/src/main/java/com/dkin/chevit/domain/repository/AuthRepository.kt

Line 21 in 14871b1

    
           suspend fun uploadProfileImage(uploadURL: String, uploadMethod: String, uploadHeaders: String, file: File)

🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Parameter should start on a newline

Chevit-Android/domain/src/main/java/com/dkin/chevit/domain/repository/AuthRepository.kt

Line 21 in 14871b1

    
           suspend fun uploadProfileImage(uploadURL: String, uploadMethod: String, uploadHeaders: String, file: File)

🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Newline expected before closing parenthesis

Chevit-Android/domain/src/main/java/com/dkin/chevit/domain/repository/AuthRepository.kt

Line 21 in 14871b1

    
           suspend fun uploadProfileImage(uploadURL: String, uploadMethod: String, uploadHeaders: String, file: File)

🚫 [ktlint] standard:function-expression-body _{reported by reviewdog 🐶}
Function body should be replaced with body expression

Chevit-Android/domain/src/main/java/com/dkin/chevit/domain/usecase/auth/GetProfileImageDataUseCase.kt

Line 12 in 14871b1

override suspend fun execute(params: Param): ProfileImageData {

🚫 [ktlint] standard:class-signature _{reported by reviewdog 🐶}
Newline expected after opening parenthesis

Chevit-Android/domain/src/main/java/com/dkin/chevit/domain/usecase/auth/GetProfileImageDataUseCase.kt

Line 17 in 14871b1

value class Param(val fileSize: Int)

🚫 [ktlint] standard:class-signature _{reported by reviewdog 🐶}
Newline expected before closing parenthesis

Chevit-Android/domain/src/main/java/com/dkin/chevit/domain/usecase/auth/GetProfileImageDataUseCase.kt

Line 17 in 14871b1

value class Param(val fileSize: Int)

🚫 [ktlint] standard:final-newline _{reported by reviewdog 🐶}
File must end with a newline (\n)

Chevit-Android/domain/src/main/java/com/dkin/chevit/domain/usecase/auth/GetProfileImageDataUseCase.kt

Line 18 in 14871b1

}

🚫 [ktlint] standard:trailing-comma-on-call-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/domain/src/main/java/com/dkin/chevit/domain/usecase/auth/UploadProfileImageUseCase.kt

Line 18 in 14871b1

file = params.file

🚫 [ktlint] standard:trailing-comma-on-declaration-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/domain/src/main/java/com/dkin/chevit/domain/usecase/auth/UploadProfileImageUseCase.kt

Line 27 in 14871b1

val file: File

🚫 [ktlint] standard:final-newline _{reported by reviewdog 🐶}
File must end with a newline (\n)

Chevit-Android/domain/src/main/java/com/dkin/chevit/domain/usecase/auth/UploadProfileImageUseCase.kt

Line 29 in 14871b1

}

🚫 [ktlint] standard:trailing-comma-on-declaration-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/EditProfileImageContents.kt

Line 27 in 14871b1

changeImage: (uri: Uri?) -> Unit

🚫 [ktlint] standard:multiline-expression-wrapping _{reported by reviewdog 🐶}
A multiline expression should start on a new line

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/EditProfileImageContents.kt

Line 29 in 14871b1

val launcher = rememberLauncherForActivityResult(

🚫 [ktlint] standard:indent _{reported by reviewdog 🐶}
Unexpected indentation (8) (should be 12)

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/EditProfileImageContents.kt

Line 31 in 14871b1

ActivityResultContracts.GetContent()

🚫 [ktlint] standard:trailing-comma-on-call-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/EditProfileImageContents.kt

Line 31 in 14871b1

ActivityResultContracts.GetContent()

🚫 [ktlint] standard:multiline-expression-wrapping _{reported by reviewdog 🐶}
A multiline expression should start on a new line

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/EditProfileImageContents.kt

Line 43 in 14871b1

modifier = Modifier

🚫 [ktlint] standard:trailing-comma-on-call-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/EditProfileImageContents.kt

Line 48 in 14871b1

}

🚫 [ktlint] standard:multiline-expression-wrapping _{reported by reviewdog 🐶}
A multiline expression should start on a new line

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/EditProfileImageContents.kt

Line 66 in 14871b1

modifier = Modifier

🚫 [ktlint] standard:trailing-comma-on-call-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/EditProfileImageContents.kt

Line 72 in 14871b1

}

🚫 [ktlint] standard:no-unused-imports _{reported by reviewdog 🐶}
Unused import

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 4 in 14871b1

import android.os.FileUtils.copy

🚫 [ktlint] standard:trailing-comma-on-call-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 78 in 14871b1

imageChanged

🚫 [ktlint] standard:trailing-comma-on-call-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 80 in 14871b1

}

🚫 [ktlint] standard:trailing-comma-on-call-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 92 in 14871b1

}

🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Newline expected after opening parenthesis

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 100 in 14871b1

    
           private fun saveProfileSetting(name: String, imageUrl: String, imageChanged: Boolean) {

🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Parameter should start on a newline

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 100 in 14871b1

    
           private fun saveProfileSetting(name: String, imageUrl: String, imageChanged: Boolean) {

🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Parameter should start on a newline

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 100 in 14871b1

    
           private fun saveProfileSetting(name: String, imageUrl: String, imageChanged: Boolean) {

🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Newline expected before closing parenthesis

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 100 in 14871b1

    
           private fun saveProfileSetting(name: String, imageUrl: String, imageChanged: Boolean) {

🚫 [ktlint] standard:multiline-expression-wrapping _{reported by reviewdog 🐶}
A multiline expression should start on a new line

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 105 in 14871b1

val file = File.createTempFile(

🚫 [ktlint] standard:chain-method-continuation _{reported by reviewdog 🐶}
Expected newline before '.'

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 115 in 14871b1

requireContext().contentResolver.openInputStream(imageUrl.toUri())

🚫 [ktlint] standard:chain-method-continuation _{reported by reviewdog 🐶}
Expected newline before '.'

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 115 in 14871b1

requireContext().contentResolver.openInputStream(imageUrl.toUri())

🚫 [ktlint] standard:multiline-expression-wrapping _{reported by reviewdog 🐶}
A multiline expression should start on a new line

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 121 in 14871b1

viewModel.dispatch(ProfileSettingIntent.SaveImageProfile(

🚫 [ktlint] standard:wrapping _{reported by reviewdog 🐶}
Missing newline after "("

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 121 in 14871b1

viewModel.dispatch(ProfileSettingIntent.SaveImageProfile(

🚫 [ktlint] standard:trailing-comma-on-call-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 124 in 14871b1

file

🚫 [ktlint] standard:wrapping _{reported by reviewdog 🐶}
Missing newline before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 125 in 14871b1

))

🚫 [ktlint] standard:multiline-expression-wrapping _{reported by reviewdog 🐶}
A multiline expression should start on a new line

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 127 in 14871b1

viewModel.dispatch(ProfileSettingIntent.SaveProfile(

🚫 [ktlint] standard:wrapping _{reported by reviewdog 🐶}
Missing newline after "("

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 127 in 14871b1

viewModel.dispatch(ProfileSettingIntent.SaveProfile(

🚫 [ktlint] standard:wrapping _{reported by reviewdog 🐶}
Missing newline before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSetting.kt

Line 130 in 14871b1

))

🚫 [ktlint] standard:blank-line-before-declaration _{reported by reviewdog 🐶}
Expected a blank line for this declaration

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingContract.kt

Line 11 in 14871b1

    
           data class SaveImageProfile(val name: String, val imageUrl: String, val file: File) : ProfileSettingIntent

🚫 [ktlint] standard:class-signature _{reported by reviewdog 🐶}
Newline expected after opening parenthesis

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingContract.kt

Line 11 in 14871b1

    
           data class SaveImageProfile(val name: String, val imageUrl: String, val file: File) : ProfileSettingIntent

🚫 [ktlint] standard:class-signature _{reported by reviewdog 🐶}
Parameter should start on a newline

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingContract.kt

Line 11 in 14871b1

    
           data class SaveImageProfile(val name: String, val imageUrl: String, val file: File) : ProfileSettingIntent

🚫 [ktlint] standard:class-signature _{reported by reviewdog 🐶}
Parameter should start on a newline

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingContract.kt

Line 11 in 14871b1

    
           data class SaveImageProfile(val name: String, val imageUrl: String, val file: File) : ProfileSettingIntent

🚫 [ktlint] standard:class-signature _{reported by reviewdog 🐶}
Newline expected before closing parenthesis

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingContract.kt

Line 11 in 14871b1

    
           data class SaveImageProfile(val name: String, val imageUrl: String, val file: File) : ProfileSettingIntent

🚫 [ktlint] standard:condition-wrapping _{reported by reviewdog 🐶}
Newline expected before operand in multiline condition

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingScreen.kt

Line 95 in 14871b1

name.isNotBlank() && name.length < 8 && settingState.imageUrl.isNotBlank()

🚫 [ktlint] standard:condition-wrapping _{reported by reviewdog 🐶}
Newline expected before operand in multiline condition

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingScreen.kt

Line 95 in 14871b1

name.isNotBlank() && name.length < 8 && settingState.imageUrl.isNotBlank()

🚫 [ktlint] standard:multiline-expression-wrapping _{reported by reviewdog 🐶}
A multiline expression should start on a new line

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingScreen.kt

Line 123 in 14871b1

modifier = Modifier

🚫 [ktlint] standard:trailing-comma-on-call-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingScreen.kt

Line 129 in 14871b1

contentAlignment = Alignment.Center

🚫 [ktlint] standard:trailing-comma-on-call-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingScreen.kt

Line 134 in 14871b1

tint = ChevitTheme.colors.white

🚫 [ktlint] standard:import-ordering _{reported by reviewdog 🐶}
Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 3 in 14871b1

import androidx.lifecycle.viewModelScope

🚫 [ktlint] standard:trailing-comma-on-declaration-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 24 in 14871b1

private val uploadProfileImageUseCase: UploadProfileImageUseCase

🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Newline expected after opening parenthesis

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 47 in 14871b1

    
           private suspend fun saveProfileWithImage(name: String, imageUrl: String, file: File,) {

🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Parameter should start on a newline

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 47 in 14871b1

    
           private suspend fun saveProfileWithImage(name: String, imageUrl: String, file: File,) {

🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Parameter should start on a newline

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 47 in 14871b1

    
           private suspend fun saveProfileWithImage(name: String, imageUrl: String, file: File,) {

🚫 [ktlint] standard:parameter-list-spacing _{reported by reviewdog 🐶}
Whitespace after ',' is missing

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 47 in 14871b1

    
           private suspend fun saveProfileWithImage(name: String, imageUrl: String, file: File,) {

🚫 [ktlint] standard:trailing-comma-on-declaration-site _{reported by reviewdog 🐶}
Unnecessary trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 47 in 14871b1

    
           private suspend fun saveProfileWithImage(name: String, imageUrl: String, file: File,) {

🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Newline expected before closing parenthesis

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 47 in 14871b1

    
           private suspend fun saveProfileWithImage(name: String, imageUrl: String, file: File,) {

🚫 [ktlint] standard:chain-method-continuation _{reported by reviewdog 🐶}
Expected newline before '.'

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 48 in 14871b1

kotlin.runCatching {

🚫 [ktlint] standard:multiline-expression-wrapping _{reported by reviewdog 🐶}
A multiline expression should start on a new line

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 50 in 14871b1

params = GetProfileImageDataUseCase.Param(

🚫 [ktlint] standard:trailing-comma-on-call-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 51 in 14871b1

fileSize = file.length().toInt()

🚫 [ktlint] standard:trailing-comma-on-call-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 52 in 14871b1

)

🚫 [ktlint] standard:trailing-comma-on-call-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 61 in 14871b1

file = file

🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Newline expected after opening parenthesis

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 69 in 14871b1

private suspend fun updateProfile(name: String, imageUrl: String) {

🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Parameter should start on a newline

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 69 in 14871b1

private suspend fun updateProfile(name: String, imageUrl: String) {

🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Newline expected before closing parenthesis

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 69 in 14871b1

private suspend fun updateProfile(name: String, imageUrl: String) {

🚫 [ktlint] standard:trailing-comma-on-declaration-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 86 in 14871b1

uploadHeaders: String

🚫 [ktlint] standard:chain-method-continuation _{reported by reviewdog 🐶}
Expected newline before '.'

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 89 in 14871b1

kotlin.runCatching {

🚫 [ktlint] standard:multiline-expression-wrapping _{reported by reviewdog 🐶}
A multiline expression should start on a new line

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 91 in 14871b1

params = UploadProfileImageUseCase.Param(

🚫 [ktlint] standard:trailing-comma-on-call-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 95 in 14871b1

file = file

🚫 [ktlint] standard:trailing-comma-on-call-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

Chevit-Android/presentation/home/src/main/java/com/dkin/chevit/presentation/home/contents/user/profile/ProfileSettingViewModel.kt

Line 96 in 14871b1

)

github-actions · 2024-10-03T08:21:31Z

data/src/debug/java/com/dkin/chevit/data/di/NetworkModule.kt

+    fun providePureOkHttpClient(
+        httpLoggingInterceptor: HttpLoggingInterceptor,
+        chuckerInterceptor: ChuckerInterceptor,
+    ) = OkHttpClient.Builder()


🚫 [ktlint] standard:chain-method-continuation _{reported by reviewdog 🐶}
Expected newline before '.'

github-actions · 2024-10-03T08:21:31Z

data/src/debug/java/com/dkin/chevit/data/di/NetworkModule.kt

+    fun providePureRetrofit(
+        @Named("Pure") okHttpClient: OkHttpClient,
+        @JsonConverter jsonConverter: Converter.Factory,
+    ): Retrofit = Retrofit.Builder()


🚫 [ktlint] standard:multiline-expression-wrapping _{reported by reviewdog 🐶}
A multiline expression should start on a new line

github-actions · 2024-10-03T08:21:31Z

data/src/debug/java/com/dkin/chevit/data/di/NetworkModule.kt

+    fun providePureRetrofit(
+        @Named("Pure") okHttpClient: OkHttpClient,
+        @JsonConverter jsonConverter: Converter.Factory,
+    ): Retrofit = Retrofit.Builder()


🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Newline expected before expression body

github-actions · 2024-10-03T08:21:31Z

data/src/debug/java/com/dkin/chevit/data/di/NetworkModule.kt

+    fun providePureRetrofit(
+        @Named("Pure") okHttpClient: OkHttpClient,
+        @JsonConverter jsonConverter: Converter.Factory,
+    ): Retrofit = Retrofit.Builder()


🚫 [ktlint] standard:chain-method-continuation _{reported by reviewdog 🐶}
Expected newline before '.'

github-actions · 2024-10-03T08:21:31Z

data/src/main/java/com/dkin/chevit/data/di/RetrofitModule.kt

+    @Provides
+    @Singleton
+    fun provideImageAPI(
+        @Named("Pure") retrofit: Retrofit


🚫 [ktlint] standard:trailing-comma-on-declaration-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

github-actions · 2024-10-03T08:21:33Z

data/src/main/java/com/dkin/chevit/data/repository/AuthRepositoryImpl.kt

+        uploadURL: String,
+        uploadMethod: String,
+        uploadHeaders: String,
+        file: File


🚫 [ktlint] standard:trailing-comma-on-declaration-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

github-actions · 2024-10-03T08:21:33Z

domain/src/main/java/com/dkin/chevit/domain/model/ProfileImageData.kt

+    val uploadMethod: String,
+    val uploadURL: String,
+    val uploadHeaders: String,
+    val imageURL: String


🚫 [ktlint] standard:trailing-comma-on-declaration-site _{reported by reviewdog 🐶}
Missing trailing comma before ")"

github-actions · 2024-10-03T08:21:33Z

domain/src/main/java/com/dkin/chevit/domain/model/ProfileImageData.kt

+    val uploadURL: String,
+    val uploadHeaders: String,
+    val imageURL: String
+) : DomainModel


🚫 [ktlint] standard:final-newline _{reported by reviewdog 🐶}
File must end with a newline (\n)

github-actions · 2024-10-03T08:21:33Z

domain/src/main/java/com/dkin/chevit/domain/repository/AuthRepository.kt

@@ -1,6 +1,9 @@
 package com.dkin.chevit.domain.repository

+import com.dkin.chevit.domain.base.None


🚫 [ktlint] standard:no-unused-imports _{reported by reviewdog 🐶}
Unused import

github-actions · 2024-10-03T08:21:33Z

domain/src/main/java/com/dkin/chevit/domain/repository/AuthRepository.kt

+
+    suspend fun getProfileUploadURL(fileSize: Int): ProfileImageData
+
+    suspend fun uploadProfileImage(uploadURL: String, uploadMethod: String, uploadHeaders: String, file: File)


🚫 [ktlint] standard:function-signature _{reported by reviewdog 🐶}
Newline expected after opening parenthesis

leesa-l added 5 commits September 12, 2024 00:32

프로필 이미지 업로드 UI, UseCase구현

1193019

image upload api 구현(미완)

fbd8c9b

file provider 추가

3fad39f

image upload api 수정

69348fd

이미지 저장되지 않는 현상 수정

14871b1

github-actions bot requested a review from kts6056 October 3, 2024 08:21

leesa-l added this pull request to the merge queue Oct 3, 2024

github-actions bot assigned leesa-l Oct 3, 2024

Merged via the queue into develop with commit b8e3e68 Oct 3, 2024
4 checks passed

leesa-l deleted the feature/profile_image branch October 3, 2024 08:21

github-actions bot reviewed Oct 3, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/profile image #47

Feature/profile image #47

leesa-l commented Oct 3, 2024

github-actions bot left a comment

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

		@@ -1,6 +1,9 @@
		package com.dkin.chevit.domain.repository

		import com.dkin.chevit.domain.base.None


		suspend fun getProfileUploadURL(fileSize: Int): ProfileImageData

		suspend fun uploadProfileImage(uploadURL: String, uploadMethod: String, uploadHeaders: String, file: File)

Feature/profile image #47

Feature/profile image #47

Conversation

leesa-l commented Oct 3, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment