Fixes issues with Async persisters #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A preview of 62dcba0 is uploaded and can be seen here: ✨ https://burr.dagworks.io/pull/495 ✨ Changes may take a few minutes to propagate. Since this is a preview of production, content with |
Moves them + adds tests for .copy(). Note we have tests for the in-memory implementation as well -- these are duplicated. We're OK with that -- sharing tests between pytest files is a bit ugly.
elijahbenizzy
force-pushed
the
async-persister-fixes
branch
from
beaee31 to
043e274
Compare
skrawcz
reviewed
Jan 11, 2025
elijahbenizzy
force-pushed
the
async-persister-fixes
branch
from
9f328e3 to
40f479e
Compare
elijahbenizzy
force-pushed
the
async-persister-fixes
branch
from
1a8d003 to
62dcba0
Compare
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 62dcba0 in 42 seconds
More details
- Looked at
1012lines of code in9files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. burr/core/persistence.py:609
- Draft comment:
The aliasAsyncSQLLitePersistershould be updated toAsyncSQLitePersisterto maintain consistency and avoid confusion. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. tests/core/test_persistence.py:4
- Draft comment:
The aliasSQLLitePersistershould be updated toSQLitePersisterto maintain consistency and avoid confusion. This issue is also present in other parts of the code, such as in thepersistenceandinitializing_persistencefixtures. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_and9EDz4yq5N5Sv2
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some issues:
@copyImportant
Fixes issues with
AsyncSQLitePersister, movesaiosqliteto plugins, and adds tests for@copymethod.AsyncSQLitePersistertoburr/integrations/persisters/b_aiosqlite.py.aiosqliteimport frompersistence.pyand added it tob_aiosqlite.py.pyproject.tomlto reflectaiosqliteas a plugin dependency.AsyncSQLitePersisterintest_b_aiosqlite.py.test_copy_persisterto verifycopy()method functionality.persister.rstto referenceAsyncSQLitePersisterin the new location.AsyncSQLitePersisterintest_persistence.pyand other files.README.mdinexamples/openai-compatible-agentwith new run instructions.This description was created by
for 62dcba0. It will automatically update as commits are pushed.