Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds one trick to pytest README #489

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Adds one trick to pytest README #489

merged 1 commit into from
Dec 28, 2024

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Dec 28, 2024

Adds example of testing for stability / variance.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Important

Adds a section in README.md for testing output stability/variance in generative models using pytest.

  • Documentation:
    • Adds a section in README.md for testing stability/variance of outputs in generative models using pytest.
    • Provides a code example test_an_actions_stability() to run actions multiple times and check output consistency.

This description was created by Ellipsis for cb28888. It will automatically update as commits are pushed.

Adds example of testing for stability / variance.
@skrawcz skrawcz merged commit 91a6b33 into main Dec 28, 2024
11 checks passed
@skrawcz skrawcz deleted the add_more_docs_to_pytest branch December 28, 2024 01:06
Copy link

github-actions bot commented Dec 28, 2024

A preview of is uploaded and can be seen here:

https://burr.dagworks.io/pull/489

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/DAGWorks-Inc/burr/tree/gh-pages/pull/489/

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to cb28888 in 1 minute and 25 seconds

More details
  • Looked at 32 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. examples/pytest/README.md:314
  • Draft comment:
    json is used but not imported. Add import json at the beginning of the code snippet.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    This is a code snippet in a README.md file, not actual implementation code. Documentation often omits imports for brevity. The code is meant to illustrate a concept rather than be directly copy-pasted. Additionally, this is a minor issue that would be immediately caught by any Python interpreter or linter if someone tried to run it.
    The comment is technically correct - the code does use json without importing it. Missing imports could confuse readers who are new to Python.
    While technically correct, this level of detail is unnecessary in documentation. The focus should be on the concept being illustrated, not implementation details that would be obvious when actually implementing.
    Delete the comment. Missing imports in documentation examples are common and acceptable, and this would be immediately caught by tools if implemented.

Workflow ID: wflow_wvsiGGiYoaTYwSgC


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant