Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more docs to the pytest example code #487

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Dec 27, 2024

Adds more docs to pytest example,.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Important

Enhances documentation and adds docstrings to examples/pytest code for better clarity and understanding.

  • Documentation:
    • Added detailed docstrings to functions and classes in some_actions.py and test_some_actions.py.
    • Updated README.md with additional notes and explanations on using pytest and Burr for testing.
  • Code Comments:
    • Added comments in some_actions.py to explain the purpose and functionality of actions and classes.
    • Enhanced comments in test_some_actions.py to clarify test cases and their expected outcomes.

This description was created by Ellipsis for a74e101. It will automatically update as commits are pushed.

@skrawcz skrawcz merged commit 34070f0 into main Dec 27, 2024
11 checks passed
@skrawcz skrawcz deleted the add_more_docs_to_pytest branch December 27, 2024 06:13
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a74e101 in 12 seconds

More details
  • Looked at 153 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. examples/pytest/some_actions.py:135
  • Draft comment:
    Consider adding descriptions for each parameter in the docstring to improve clarity and completeness.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds documentation to the code, which is generally good. However, there are some areas where the documentation could be improved for clarity and completeness.
2. examples/pytest/some_actions.py:160
  • Draft comment:
    Consider adding descriptions for each parameter in the docstring to improve clarity and completeness.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds documentation to the code, which is generally good. However, there are some areas where the documentation could be improved for clarity and completeness.
3. examples/pytest/some_actions.py:107
  • Draft comment:
    Consider adding descriptions for each parameter in the docstring to improve clarity and completeness.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds documentation to the code, which is generally good. However, there are some areas where the documentation could be improved for clarity and completeness.

Workflow ID: wflow_a1MJgDGMzEjSW96q


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Dec 27, 2024

A preview of is uploaded and can be seen here:

https://burr.dagworks.io/pull/487

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/DAGWorks-Inc/burr/tree/gh-pages/pull/487/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant