Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI fixes #480

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Minor UI fixes #480

merged 3 commits into from
Dec 16, 2024

Conversation

elijahbenizzy
Copy link
Contributor

@elijahbenizzy elijahbenizzy commented Dec 16, 2024

Important

Minor UI fixes in telemetry components to handle undefined data and improve table rendering.

  • UI Improvements:
    • In AppView.tsx, handle undefined annotationsData by defaulting to an empty array.
    • In StepList.tsx, remove redundant class concatenation in StepSubTableRow.
    • Ensure TableCell is always rendered in StepSubTableRow regardless of displayAnnotations.
  • Debugging:
    • Add console.log for projectId, appId, and partitionKey in MiniTelemetry.tsx for debugging purposes.

This description was created by Ellipsis for 61e8e24. It will automatically update as commits are pushed.

The mini-telemetry never showed up -- this is because we relied on
annotations being loaded but skipped them if the BE does not support it.
Previously we had a weird flex that caused the table row to be overly
tall. This fixes it.
Copy link

github-actions bot commented Dec 16, 2024

A preview of 2bbcd45 is uploaded and can be seen here:

https://burr.dagworks.io/pull/480

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/DAGWorks-Inc/burr/tree/gh-pages/pull/480/

@elijahbenizzy elijahbenizzy merged commit 72d2797 into main Dec 16, 2024
12 checks passed
@elijahbenizzy elijahbenizzy deleted the minor-ui-fixes branch December 16, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant