Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds BentoML to docs & examples #470

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Adds BentoML to docs & examples #470

merged 2 commits into from
Dec 12, 2024

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Dec 11, 2024

Adds bentoml links

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Important

Adds BentoML deployment option and example to documentation and examples.

  • Documentation:
    • Adds BentoML deployment option in infrastructure.rst and web-server.rst.
    • Describes BentoML as a tool for packaging, deploying, and managing AI services in infrastructure.rst.
  • Examples:
    • Adds BentoML example submodule examples/deployment/bentoml/BentoBurr.

This description was created by Ellipsis for a8023e5. It will automatically update as commits are pushed.

Chose gitsubmodule because I'm lazy for the example code.
Otherwise added a some documentation references.
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ffcab92 in 40 seconds

More details
  • Looked at 47 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. docs/examples/deployment/infrastructure.rst:9
  • Draft comment:
    The link to the BentoML example seems incorrect. It points to examples/deployment/aws/bentoml, but it should likely be examples/deployment/bentoml/BentoBurr. Please verify the correct path.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. docs/examples/deployment/web-server.rst:16
  • Draft comment:
    The link to the BentoML example seems incorrect. It points to examples/deployment/aws/bentoml, but it should likely be examples/deployment/bentoml/BentoBurr. Please verify the correct path.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_X40jSAq8K9q4NoJn


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Dec 11, 2024

A preview of a8023e5 is uploaded and can be seen here:

https://burr.dagworks.io/pull/470

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/DAGWorks-Inc/burr/tree/gh-pages/pull/470/

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on a8023e5 in 23 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. docs/examples/deployment/infrastructure.rst:16
  • Draft comment:
    The link to the BentoML example seems incorrect. It should be examples/deployment/bentoml/BentoBurr instead of examples/deployment/aws/bentoml. Please update the link to point to the correct path.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_Pnh543HormAEjWMO


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@skrawcz skrawcz merged commit b70baf6 into main Dec 12, 2024
11 checks passed
@skrawcz skrawcz deleted the add_bentoml branch December 12, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant