Skip to content

Commit

Permalink
Fixes issue with Burr demo
Browse files Browse the repository at this point in the history
The mini-telemetry never showed up -- this is because we relied on
annotations being loaded but skipped them if the BE does not support it.
  • Loading branch information
elijahbenizzy committed Dec 16, 2024
1 parent 06562a3 commit db19afd
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions telemetry/ui/src/components/routes/app/AppView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -392,8 +392,9 @@ export const AppView = (props: {
}

if (error) return <div>Error loading steps</div>;
if (data === undefined || backendSpec === undefined || annotationsData === undefined)
if (data === undefined || backendSpec === undefined) {
return <Loading />;
}
const displayAnnotations = props.allowAnnotations && backendSpec.supports_annotations;
// TODO -- re-enable this if I want...
// const previousActions =
Expand Down Expand Up @@ -513,7 +514,7 @@ export const AppView = (props: {
setTopToBottomChronological={setTopToBottomChronological}
toggleInspectViewOpen={() => setInspectViewOpen(!inspectViewOpen)}
displayAnnotations={displayAnnotations}
annotations={annotationsData}
annotations={annotationsData || []}
/>
</div>
{!fullScreen && props.orientation === 'stacked_horizontal' && (
Expand Down

0 comments on commit db19afd

Please sign in to comment.