Use ZeroLog.LogManager.Flush()
in benchmarks
#176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates ZeroLog in benchmarks and replaces some usages of its
LogManager.Shutdown
method withLogManager.Flush
.When I sent #127, I made a note that we should expose a
Flush
method for benchmarking, as I had to useShutdown
, which worked but was incorrect (it allocates, takes a longer time, does more than necessary, etc). We were using an internalWaitUntilQueueIsEmpty
method in ZeroLog benchmarks but I couldn't use it here. Oops. 😅This PR therefore uses the new
Flush
method where it is the correct thing to do. Benchmark results are barely affected though.