Skip to content

Commit

Permalink
Update arg to node_version (#129)
Browse files Browse the repository at this point in the history
* Update node version argument and comments
  • Loading branch information
muhammad9970 authored and tim-s-ccs committed Nov 10, 2023
1 parent 89b7ea4 commit 207d921
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
# Pass in nodejs version
ARG NODE_MAJOR=20.0.0
ARG NODE_VERSION=20.0.0

# Pull in the nodejs image
FROM node:${NODE_MAJOR}-alpine AS node
FROM node:${NODE_VERSION}-alpine AS node

# Pull in relevant ruby image
FROM ruby:3.2.2-alpine

# As it is a multistage build
# We will pull in the contents from the previous node image
# To our current ruby image
# As this is a multistage Docker image build
# we will pull in the contents from the previous node image build stage
# to our current ruby build image stage
# so that the ruby image build stage has the correct nodejs version
COPY --from=node /usr/lib /usr/lib
COPY --from=node /usr/local/share /usr/local/share
COPY --from=node /usr/local/lib /usr/local/lib
Expand Down

0 comments on commit 207d921

Please sign in to comment.