Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: if target is not <a> element, don't handle onClick event #53

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

RuslanZavacky
Copy link
Collaborator

If you want to handle multiple elements with single event listener on parent element, this change allows it and don't throw any errors.

In cases like this, we were throwing an error, as the direct listener wasn't on the Anchor element. Now we'll handle those cases appropriately.

document.querySelector('[data-internal-links]')
      .addEventListener('click', (event) => falcon.navigation.onClick(event, '_self', 'internal'));

If you want to handle multiple <a> elements with single event listener on parent element, this change allows it and don't throw any errors.
Copy link

changeset-bot bot commented Nov 17, 2023

🦋 Changeset detected

Latest commit: 2000545

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crowdstrike/foundry-js Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@RuslanZavacky RuslanZavacky merged commit 7cfe7a1 into main Nov 22, 2023
1 check passed
@RuslanZavacky RuslanZavacky deleted the improve-navigation branch November 22, 2023 15:09
@github-actions github-actions bot mentioned this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant