Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update embroider monorepo to v3 (major) #163

Closed
wants to merge 2 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 17, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@embroider/compat ^2.0.0 -> ^3.0.0 age adoption passing confidence
@embroider/core ^2.0.0 -> ^3.0.0 age adoption passing confidence
@embroider/test-setup ^2.0.0 -> ^3.0.0 age adoption passing confidence
@embroider/webpack ^2.0.0 -> ^3.0.0 age adoption passing confidence

Release Notes

embroider-build/embroider (@​embroider/compat)

v3.0.0

  • BREAKING: @embroider/addon-template/template-transform-plugin is removed
    because babel-plugin-ember-template-compilation >= 2.0.0 now directly supports
    source-to-source transformation.

    This plugin was used to run any custom AST transformations on your templates before publishing. To replace it:

    1. Add babel-plugin-ember-template-compilation@^2.0.0 as a devDependency.

    2. Make sure you also have a devDependency on ember-source, so we have a template compiler.

    3. Update the babel config like:

      plugins: [
      -   [
      -     '@​embroider/addon-dev/template-transform-plugin',
      -     {
      -       astTransforms: [
      -         ...yourPluginsHere
      -       ]
      -     }
      -   ],
      +   [
      +     'babel-plugin-ember-template-compilation',
      +     {
      +       compilerPath: 'ember-source/dist/ember-template-compiler',
      +       targetFormat: 'hbs',
      +       transforms: [
      +         ...yourPluginsHere
      +        ]
      +     }
      +   ]
      ]

    See https://github.com/emberjs/babel-plugin-ember-template-compilation for the complete docs on these options.

embroider-build/embroider (@​embroider/core)

v3.0.0

  • BREAKING: @embroider/addon-template/template-transform-plugin is removed
    because babel-plugin-ember-template-compilation >= 2.0.0 now directly supports
    source-to-source transformation.

    This plugin was used to run any custom AST transformations on your templates before publishing. To replace it:

    1. Add babel-plugin-ember-template-compilation@^2.0.0 as a devDependency.

    2. Make sure you also have a devDependency on ember-source, so we have a template compiler.

    3. Update the babel config like:

      plugins: [
      -   [
      -     '@​embroider/addon-dev/template-transform-plugin',
      -     {
      -       astTransforms: [
      -         ...yourPluginsHere
      -       ]
      -     }
      -   ],
      +   [
      +     'babel-plugin-ember-template-compilation',
      +     {
      +       compilerPath: 'ember-source/dist/ember-template-compiler',
      +       targetFormat: 'hbs',
      +       transforms: [
      +         ...yourPluginsHere
      +        ]
      +     }
      +   ]
      ]

    See https://github.com/emberjs/babel-plugin-ember-template-compilation for the complete docs on these options.

embroider-build/embroider (@​embroider/test-setup)

v3.0.0

  • BREAKING: @embroider/addon-template/template-transform-plugin is removed
    because babel-plugin-ember-template-compilation >= 2.0.0 now directly supports
    source-to-source transformation.

    This plugin was used to run any custom AST transformations on your templates before publishing. To replace it:

    1. Add babel-plugin-ember-template-compilation@^2.0.0 as a devDependency.

    2. Make sure you also have a devDependency on ember-source, so we have a template compiler.

    3. Update the babel config like:

      plugins: [
      -   [
      -     '@​embroider/addon-dev/template-transform-plugin',
      -     {
      -       astTransforms: [
      -         ...yourPluginsHere
      -       ]
      -     }
      -   ],
      +   [
      +     'babel-plugin-ember-template-compilation',
      +     {
      +       compilerPath: 'ember-source/dist/ember-template-compiler',
      +       targetFormat: 'hbs',
      +       transforms: [
      +         ...yourPluginsHere
      +        ]
      +     }
      +   ]
      ]

    See https://github.com/emberjs/babel-plugin-ember-template-compilation for the complete docs on these options.

embroider-build/embroider (@​embroider/webpack)

v3.0.0

  • BREAKING: @embroider/addon-template/template-transform-plugin is removed
    because babel-plugin-ember-template-compilation >= 2.0.0 now directly supports
    source-to-source transformation.

    This plugin was used to run any custom AST transformations on your templates before publishing. To replace it:

    1. Add babel-plugin-ember-template-compilation@^2.0.0 as a devDependency.

    2. Make sure you also have a devDependency on ember-source, so we have a template compiler.

    3. Update the babel config like:

      plugins: [
      -   [
      -     '@​embroider/addon-dev/template-transform-plugin',
      -     {
      -       astTransforms: [
      -         ...yourPluginsHere
      -       ]
      -     }
      -   ],
      +   [
      +     'babel-plugin-ember-template-compilation',
      +     {
      +       compilerPath: 'ember-source/dist/ember-template-compiler',
      +       targetFormat: 'hbs',
      +       transforms: [
      +         ...yourPluginsHere
      +        ]
      +     }
      +   ]
      ]

    See https://github.com/emberjs/babel-plugin-ember-template-compilation for the complete docs on these options.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2023

⚠️ No Changeset found

Latest commit: 608f781

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renovate renovate bot force-pushed the renovate/major-embroider-monorepo branch 3 times, most recently from 5f37d63 to 4bdf5d7 Compare May 25, 2023 19:25
@renovate renovate bot force-pushed the renovate/major-embroider-monorepo branch from 4bdf5d7 to 77baa7f Compare May 29, 2023 23:07
@renovate renovate bot force-pushed the renovate/major-embroider-monorepo branch 3 times, most recently from a6159ff to b160598 Compare June 9, 2023 17:03
@renovate renovate bot force-pushed the renovate/major-embroider-monorepo branch 10 times, most recently from 2fea029 to b98b7cb Compare June 20, 2023 13:53
@renovate renovate bot force-pushed the renovate/major-embroider-monorepo branch from b98b7cb to b8447d0 Compare June 20, 2023 21:14
@ynotdraw
Copy link
Contributor

This PR is failing due to the docs-app failing to build due to:

docs-app:build: $TMPDIR/embroider/e83321/docs-app/templates/application.hbs/application.hbs: unsupported ambiguity between helper and component: this use of "{{page-title}}" could be helper "{{ (page-title) }}" or component "<PageTitle />", and your settings for staticHelpers and staticComponents do not agree. Either switch to one of the unambiguous forms, or make staticHelpers and staticComponents agree, or use a "disambiguate" packageRule to work around the problem if its in third-party code you cannot easily fix. in templates/application.hbs

I'm taking a look.

@renovate
Copy link
Contributor Author

renovate bot commented Jun 21, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@ynotdraw
Copy link
Contributor

Going to go ahead and close as this will need to be a manual PR anyway. Tracking the embroider upgrade over on #210.

@ynotdraw ynotdraw closed this Jul 24, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Jul 24, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 3.x releases. But if you manually upgrade to 3.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/major-embroider-monorepo branch July 24, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant