Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add identifier property to Entity attributes #59

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Conversation

martin-fleck-at
Copy link
Collaborator

  • Highlight identifier attributes by underlining their name
  • Allow to set identifier property in Entity form

Copy link

github-actions bot commented Jun 27, 2024

Unit Test Results

  3 files  ±0   30 suites  ±0   2m 59s ⏱️ +27s
 71 tests ±0   71 ✅ ±0  0 💤 ±0  0 ❌ ±0 
216 runs  ±0  216 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 24c8d0e. ± Comparison against base commit 7a4872a.

♻️ This comment has been updated with latest results.

- Highlight identifier attributes by underlining their name
- Allow to set identifier property in Entity form
@harmen-xb
Copy link
Contributor

@martin-fleck-at

Nice work.

Some remarks:

@martin-fleck-at
Copy link
Collaborator Author

@harmen-xb Sure, I pushed an update that should make all the changes that you requests.

Copy link
Contributor

@harmen-xb harmen-xb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@harmen-xb
Copy link
Contributor

@martin-fleck-at One last question to discuss in 5 minutes, is it simple to change the structure diagram to show the key icon in front of key attributes i.s.o. the underline?

@martin-fleck-at
Copy link
Collaborator Author

I pushed an update that changes the underline for a key icon.

@harmen-xb
Copy link
Contributor

Yes, that looks way better :). Thanks!

@harmen-xb harmen-xb merged commit 789eb75 into main Jun 28, 2024
5 checks passed
@harmen-xb harmen-xb deleted the feature/identifier branch June 28, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants